public inbox for buildbot@sourceware.org
 help / color / mirror / Atom feed
From: Mark Wielaard <mark@klomp.org>
To: buildbot@sourceware.org
Cc: Mark Wielaard <mark@klomp.org>
Subject: [PATCH] glibc-build: haltOnFailure for glibc_make_build_step
Date: Tue,  5 Jul 2022 13:19:26 +0200	[thread overview]
Message-ID: <20220705111926.12610-1-mark@klomp.org> (raw)

It doesn't really make sense to continue with the check step if the
build itself fails.
---
 builder/master.cfg | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/builder/master.cfg b/builder/master.cfg
index d9684a6..19e8d1b 100644
--- a/builder/master.cfg
+++ b/builder/master.cfg
@@ -2551,7 +2551,7 @@ glibc_make_build_step = steps.Compile(
         command=['make',
                  util.Interpolate('-j%(prop:ncpus)s')],
         name='make',
-        haltOnFailure=False, flunkOnFailure=True)
+        haltOnFailure=True)
 
 glibc_check_step = steps.Test(
         workdir='glibc-build',
-- 
2.30.2


                 reply	other threads:[~2022-07-05 11:19 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220705111926.12610-1-mark@klomp.org \
    --to=mark@klomp.org \
    --cc=buildbot@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).