From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (gnu.wildebeest.org [45.83.234.184]) by sourceware.org (Postfix) with ESMTPS id 593633857413 for ; Tue, 5 Jul 2022 11:19:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 593633857413 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org Received: from reform (deer0x0e.wildebeest.org [172.31.17.144]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 578E2302AB2C; Tue, 5 Jul 2022 13:19:28 +0200 (CEST) Received: by reform (Postfix, from userid 1000) id 1FC602E831CB; Tue, 5 Jul 2022 13:19:28 +0200 (CEST) From: Mark Wielaard To: buildbot@sourceware.org Cc: Mark Wielaard Subject: [PATCH] glibc-build: haltOnFailure for glibc_make_build_step Date: Tue, 5 Jul 2022 13:19:26 +0200 Message-Id: <20220705111926.12610-1-mark@klomp.org> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: buildbot@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "The https://builder.sourceware.org/ buildbot" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Jul 2022 11:19:30 -0000 It doesn't really make sense to continue with the check step if the build itself fails. --- builder/master.cfg | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/builder/master.cfg b/builder/master.cfg index d9684a6..19e8d1b 100644 --- a/builder/master.cfg +++ b/builder/master.cfg @@ -2551,7 +2551,7 @@ glibc_make_build_step = steps.Compile( command=['make', util.Interpolate('-j%(prop:ncpus)s')], name='make', - haltOnFailure=False, flunkOnFailure=True) + haltOnFailure=True) glibc_check_step = steps.Test( workdir='glibc-build', -- 2.30.2