Re: ☠ Buildbot (GNU Toolchain): gccrust - failed 'make clean' (failure) (master)

Re: ☠ Buildbot (GNU Toolchain): gccrust - failed 'make clean' (failure) (master)

[Mark Wielaard]

[-- Attachment #1: Type: text/plain, Size: 1355 bytes --]

Hi,

On Fri, Jul 22, 2022 at 12:49:54AM +0200, Mark Wielaard wrote:
> On Thu, Jul 21, 2022 at 10:38:18PM +0000, builder--- via Gcc-rust wrote:
> > A new failure has been detected on builder gccrust-bootstrap-debian-amd64 while building gccrust.
> > 
> > Full details are available at:
> >     https://builder.sourceware.org/buildbot/#builders/107/builds/43
> > 
> > Build state: failed 'make clean' (failure)
> > Revision: 51f03d9d697b0f3fed65f85e88ce41d424c844fb
> > Worker: bb2
> > Build Reason: (unknown)
> > Blamelist: Thomas Schwinge <thomas@codesourcery.com>
> > 
> > Steps:
> > [...] 
> > - 16: make clean ( failure )
> >     Logs:
> >         - stdio: https://builder.sourceware.org/buildbot/#builders/107/builds/43/steps/16/logs/stdio
> 
> Sorry, this was supposed to simply be to save some space at the end
> of the build:
> https://sourceware.org/pipermail/buildbot/2022q3/000162.html
>
> Apparently make clean doesn't work as expected. I will try to look
> into it, but it might take one or two days till I have
> time. Apologies for the mess.

It only happens after a boostrap build. But I couldn't really figure
out what is going wrong. It looks like some parts of make clean
require bash while the debian-stable tester uses dash as default. For
now I just remove the whole build tree at the end instead of running
make clean.

Cheers,

Mark

[-- Attachment #2: 0001-Don-t-make-clean-after-a-gccrs-bootstrap.patch --]
[-- Type: text/plain, Size: 1216 bytes --]

From f2db122660f2f03632253493dd7ae801e9567056 Mon Sep 17 00:00:00 2001
From: Mark Wielaard <mark@klomp.org>
Date: Fri, 22 Jul 2022 16:39:58 +0200
Subject: [PATCH] Don't make clean after a gccrs bootstrap

It looks like after a bootstrap make clean gets confused.
Just blow away the whole builddir when we are done with it.
---
 builder/master.cfg | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/builder/master.cfg b/builder/master.cfg
index 2047eaa..0d94e67 100644
--- a/builder/master.cfg
+++ b/builder/master.cfg
@@ -1686,7 +1686,10 @@ gccrust_bootstrap_factory.addStep(gccrust_make_bootstrap_step)
 gccrust_bootstrap_factory.addStep(gccrust_check_bootstrap_step)
 gccrust_bootstrap_factory.addStep(gccrust_check_check_step)
 gccrust_bootstrap_factory.addSteps(gccrust_bunsen_steps)
-gccrust_bootstrap_factory.addStep(gccrust_make_clean_step)
+# It looks like after a bootstrap make clean gets confused
+# Just blow away the whole builddir when we are done with it
+#gccrust_bootstrap_factory.addStep(gccrust_make_clean_step)
+gccrust_bootstrap_factory.addStep(gccrust_rm_build_step)
 
 gccrust_fedora_x86_64_builder = util.BuilderConfig(
         name="gccrust-fedora-x86_64",
-- 
2.31.1