public inbox for
 help / color / mirror / Atom feed
* [PATCH] Add defaultWhenFalse=False to make_output_sync util.Property
@ 2023-01-15 22:14 Mark Wielaard
  0 siblings, 0 replies; only message in thread
From: Mark Wielaard @ 2023-01-15 22:14 UTC (permalink / raw)
  To: buildbot; +Cc: Mark Wielaard

The default value is used when the property doesn’t exist, or when
the value is something Python regards as False. And Python regards
the empty string as False. So add defaultWhenFalse=False to force
Buildbot to use the default argument only if the parameter is not
 builder/master.cfg | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/builder/master.cfg b/builder/master.cfg
index a887e88..d623924 100644
--- a/builder/master.cfg
+++ b/builder/master.cfg
@@ -968,7 +968,8 @@ getversion_step = steps.SetPropertyFromCommand(
 # Allows a worker to override argument (with the empty string)
 # if make doesn't support --output-sync=line
 make_output_sync = util.Property('make_output_sync_arg',
-                                 default='--output-sync=line')
+                                 default='--output-sync=line',
+                                 defaultWhenFalse=False)
 make_step = steps.Compile(
         command=["make", make_output_sync, util.Interpolate('-j%(prop:ncpus)s')],

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2023-01-15 22:14 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-15 22:14 [PATCH] Add defaultWhenFalse=False to make_output_sync util.Property Mark Wielaard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).