From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (gnu.wildebeest.org [45.83.234.184]) by sourceware.org (Postfix) with ESMTPS id 888313858D35 for ; Tue, 31 Jan 2023 09:31:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 888313858D35 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org Received: by gnu.wildebeest.org (Postfix, from userid 1000) id 9D70330067B1; Tue, 31 Jan 2023 10:31:17 +0100 (CET) Date: Tue, 31 Jan 2023 10:31:17 +0100 From: Mark Wielaard To: Sam James Cc: buildbot@sourceware.org Subject: Re: [PATCH 2/2] gcc_full_build_factory: call contrib/test_summary after make check Message-ID: <20230131093117.GH11361@gnu.wildebeest.org> References: <20230131015611.1989999-1-sam@gentoo.org> <20230131015611.1989999-2-sam@gentoo.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230131015611.1989999-2-sam@gentoo.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-Spam-Status: No, score=-3037.6 required=5.0 tests=BAYES_00,GIT_PATCH_0,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,KAM_SHORT,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, Jan 31, 2023 at 01:56:11AM +0000, Sam James wrote: > This gives us a nice summary of the various dejagnu results. Looks like a nice idea in general. But it also renames the *.sum files to .sum.sent, which means they next bunsen step will fail to fetch them. You need to add -t: prevents logs from being renamed Also the "wrapper" text about emailing the sums is a little odd imho. But it looks like there is no way to suppress that. Cheers, Mark > --- > builder/master.cfg | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/builder/master.cfg b/builder/master.cfg > index 71efbe9..562e794 100644 > --- a/builder/master.cfg > +++ b/builder/master.cfg > @@ -3259,6 +3259,13 @@ def gcc_full_build_factory_gen(extra_configure_arg=None): > name='make check', > timeout=3600, > haltOnFailure=False, flunkOnFailure=True)) > + # Get a useful summary (repeats the various dejagnu summaries) at > + # the end. From https://gcc.gnu.org/install/test.html. > + gcc_full_build_factory.addStep(steps.Test( > + workdir='gcc-build', > + command=['../gcc/contrib/test_summary'], > + name='contrib/test_summary', > + haltOnFailure=False, flunkOnFailure=True)) > gcc_full_build_factory.addSteps(bunsen_logfile_upload_cpio_steps( > ["*.log", "*.sum"], > workdir='gcc-build')) > -- > 2.39.1 >