From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (gnu.wildebeest.org [45.83.234.184]) by sourceware.org (Postfix) with ESMTPS id F37C73858CD1; Sat, 2 Sep 2023 14:27:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F37C73858CD1 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org Received: by gnu.wildebeest.org (Postfix, from userid 1000) id 0BDB53021DEC; Sat, 2 Sep 2023 16:27:01 +0200 (CEST) Date: Sat, 2 Sep 2023 16:27:01 +0200 From: Mark Wielaard To: Sam James Cc: buildbot@sourceware.org, binutils@sourceware.org Subject: Re: =?utf-8?B?4pidIEJ1aWxkYm90IChTb3VyY2V3?= =?utf-8?Q?are=29?= =?utf-8?Q?=3A?= binutils-gdb - retry lost connection test (retry) (master) Message-ID: <20230902142701.GA25918@gnu.wildebeest.org> References: <20230901111712.119DD3857728@sourceware.org> <87zg26ceyt.fsf@gentoo.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87zg26ceyt.fsf@gentoo.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-Spam-Status: No, score=-3028.9 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Sam, On Fri, Sep 01, 2023 at 12:25:26PM +0100, Sam James wrote: > > builder--- via Binutils writes: > > > A retry build has been detected on builder binutils-gentoo-sparc while building binutils-gdb. > > I just rebooted him, so this is fine. > > Can we disable these announcements for retries? We have the following two notifiers for binutils: # Problem report for the whole binutils tagged builder set generator_binutils = reporters.BuildSetStatusGenerator( mode=('problem',), tags=['binutils']) mn_binutils = reporters.MailNotifier( fromaddr="builder@sourceware.org", sendToInterestedUsers=True, generators=[generator_binutils]) c['services'].append(mn_binutils) # Change report for the whole binutils tagged builder set generator_binutils_change = reporters.BuildSetStatusGenerator( mode=('change',), tags=['binutils']) mn_binutils_change = reporters.MailNotifier( fromaddr="builder@sourceware.org", sendToInterestedUsers=False, extraRecipients=['binutils@sourceware.org'], generators=[generator_binutils_change]) c['services'].append(mn_binutils_change) The first sents email to the patch author(s). The second to binutils mailinglist. The first for mode=('problem',) in the whole buildset, the second for mode=('change',) also in the whole buildset. https://docs.buildbot.net/current/manual/configuration/report_generators/buildset.html#buildsetstatusgenerator 'problem' Include a build which failed when the previous build has passed. 'change' Include builds which change status. So the first seems fine. But 'change' isn't really what we want. It would be nice to have something like 'problem', '!problem', so you get builds that failed when the previous build has passed and builds that passed when the previous builds failed. But 'change' contains all transformations. Should we change the second to mode=('problem',) too? You would only get a report of there was a new failure, not when the problem has been resolved. And if we do, maybe change the forst from 'problem' to 'change'? So patch authors get a notice about any change in the buildset (probably) caused by their patch? Cheers, Mark