From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (gnu.wildebeest.org [45.83.234.184]) by sourceware.org (Postfix) with ESMTPS id 48CCF3858D34 for ; Mon, 11 Mar 2024 21:52:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 48CCF3858D34 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 48CCF3858D34 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=45.83.234.184 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710193959; cv=none; b=swIzo9loT7CKYZjrxbhfCMSb7TxLlthfaoGb6VoOD6lI9L29BcOfF4lzH/Y9YMXaIHNftL0iz65lTKiVR+cvVCL15j6QvsIEY/vLyXJGVqWbdb1ngrzDjRLEDvBtJcu5AfUFo4QRazFy2p4QdEabOxGzB1S4bBgaKK1X4fZBIM8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710193959; c=relaxed/simple; bh=y1KYhY99Pjayl8tRffUlQb1zmp8EeF7OgvSHm9khgIs=; h=Date:From:To:Subject:Message-ID:MIME-Version; b=u4Ygnv93SgluZ7PZ1Hx5Om2yGKPgvJbtii7VfwcQ2ovp+vkyJE0chYPgzCGcYNUng+gVy+So3dJ4NoJemIKFdqDy58kbdEINpC5b6+akESiiPvGhnpmxuWO03OI4u7q4+4j0qP/YuhsE/5SF1eV03Cuzj46gDm9tGFItd3Xx6zo= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by gnu.wildebeest.org (Postfix, from userid 1000) id 1C8833000472; Mon, 11 Mar 2024 22:52:37 +0100 (CET) Date: Mon, 11 Mar 2024 22:52:37 +0100 From: Mark Wielaard To: Sam James Cc: Simon Marchi , buildbot@sourceware.org Subject: Re: [PATCH 0/8] Some changes to autoregen.py Message-ID: <20240311215237.GH30331@gnu.wildebeest.org> References: <20240311190341.235331-1-simon.marchi@efficios.com> <87o7bkmqep.fsf@gentoo.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87o7bkmqep.fsf@gentoo.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi, On Mon, Mar 11, 2024 at 09:04:14PM +0000, Sam James wrote: > Simon Marchi writes: > > > The first half of the patches are cleanups to make autoregen.py clean in > > the eyes of some tools I usually use for Python code. > > > > The rest of the patches make the script log a bit more. My main wish is > > for the script to print the shell commands it executes. > > The series LGTM and tested it. Same here. gcc works as expected. binutils-gdb does now show that ordering difference in gdb/aclocal.m4. I think it is a little too verbose now. Printing the ENV seems a bit busy. But for being clear what exactly is happening I guess it is nice. Pushed, Mark