From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (gnu.wildebeest.org [45.83.234.184]) by sourceware.org (Postfix) with ESMTPS id 2398B3858C36 for ; Wed, 13 Mar 2024 08:58:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2398B3858C36 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2398B3858C36 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=45.83.234.184 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710320316; cv=none; b=VoyewVYlABYhXB2sv1rttoSEZL6aVYAA9e9WzmYn/Q3IPQ3JBVV1s7SqGwPm3O6/v/KrBDl060b8tVAUrVoXxVeBFUFO7rAHBuH/DIK/hQDR+h41BanSAJslcIIdpPGFuicJb4uAHW56GakhbTZZDOTI6H0wGsHRPy6IosAsUzY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710320316; c=relaxed/simple; bh=uTusLxVAFMLsptQAcP6Oirh/SV8oZQFUDnS/iSh0bvM=; h=Date:From:To:Subject:Message-ID:MIME-Version; b=iLh45hBto4vpf40FIyOa9vZHbJnXe5rdCmnqASokj/Op3PJIEeGT8r/lhLSWKe8rLtI/BUcbXtqEsztccSKEhrvJm1gAsyaLDgJYSPSIbxRYeWtAhUNrWN2Mm53RGcexh5EpQ4NIlQj3NRzsGFl+plSiaYblb9P9/t06jNF+dVQ= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by gnu.wildebeest.org (Postfix, from userid 1000) id 458143000472; Wed, 13 Mar 2024 09:58:34 +0100 (CET) Date: Wed, 13 Mar 2024 09:58:34 +0100 From: Mark Wielaard To: Simon Marchi Cc: Arsen =?utf-8?Q?Arsenovi=C4=87?= , buildbot@sourceware.org Subject: Re: [PATCH 2/8] autoregen.py: fix a pyright `reportConstantRedefinition` warning Message-ID: <20240313085834.GO30331@gnu.wildebeest.org> References: <20240311190341.235331-1-simon.marchi@efficios.com> <20240311190341.235331-3-simon.marchi@efficios.com> <871q8f7jx5.fsf@aarsen.me> <75976ed0-ecfc-4abc-9ce7-3188059d4169@efficios.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <75976ed0-ecfc-4abc-9ce7-3188059d4169@efficios.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi, On Tue, Mar 12, 2024 at 12:00:30PM -0400, Simon Marchi wrote: > On 3/12/24 07:39, Arsen Arsenović wrote: > > Though, if I am correct, we could also just use subprocess.runs env= > > parameter to put up a modified env. > > Yeah that makes more sense. See patch below that implements this. Looks good. Applied, Mark