From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=jEzF=KT=klomp.org=mark@sourceware.org>
Received: from gnu.wildebeest.org (gnu.wildebeest.org [45.83.234.184])
	by sourceware.org (Postfix) with ESMTPS id 0F5453858CDB
	for <buildbot@sourceware.org>; Wed, 13 Mar 2024 09:15:16 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0F5453858CDB
Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org
ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0F5453858CDB
Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=45.83.234.184
ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710321317; cv=none;
	b=U7wNbvtZp3BS9B8OeW7Bl0Pb1ddDCVAH1oPvbSDVqFMWq+aP+7OfkQdi5gxxaZAykM9ZHsC5CLlT6c0HnUBND8ozWwjFoP2iAXl0ylJbYwSlV0Xt04wEdD45SgrDR7shU9dOPAejPaKXw+/EBtQ1wcGmFDSRSXufkg8MPH5HUoU=
ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key;
	t=1710321317; c=relaxed/simple;
	bh=gKKFumMGfRHZVgUX/4ofmt8H6jMPM/k0rn7PhCBClUc=;
	h=Date:From:To:Subject:Message-ID:MIME-Version; b=YCUJBRkQujEpz+oM2puR/X2EByENX0dhVFsLIOabTCYUXioGAd5Y7j+h6J7zYIs7dP58Db/S+vU8bm4Cg1JcHMoOMKJ3/0sNbup/3CqrbKMhuK9eaqCxZ9mlxFaDN4GFRgIXmhg06ldF5DzqdxjfsRJx3rht8UwEnbqLziybybQ=
ARC-Authentication-Results: i=1; server2.sourceware.org
Received: by gnu.wildebeest.org (Postfix, from userid 1000)
	id 315503000472; Wed, 13 Mar 2024 10:15:15 +0100 (CET)
Date: Wed, 13 Mar 2024 10:15:15 +0100
From: Mark Wielaard <mark@klomp.org>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: buildbot@sourceware.org
Subject: Re: [PATCH] autoregen.py: use autoreconf in some directories
Message-ID: <20240313091515.GP30331@gnu.wildebeest.org>
References: <20240312175341.239513-1-simon.marchi@polymtl.ca>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240312175341.239513-1-simon.marchi@polymtl.ca>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <buildbot.sourceware.org>

Hi Simon,

On Tue, Mar 12, 2024 at 01:53:37PM -0400, Simon Marchi wrote:
> The builder currently mis-generates the config files for the gdb and
> gnulib directories.  It passes `-I ../config` to aclocal, causing the
> include path order to be different to what it would be without that -I
> argument, causing the generated aclocal.m4 to be different (same entries
> but different order).
> 
> For the gdb, gdbserver, gdbsupport and gnulib directories, the config
> files are usually re-generated without any -I argument.  In fact, for
> gnulib, it is baked in gnulib/update-gnulib.sh that aclocal should be
> called without -I arguments:
> 
>     aclocal &&
>     autoconf &&
>     autoheader &&
>     automake
> 
> Moreover, they can be re-generated using autoreconf, removing the need
> to guess which speicific tools need to be invoked.  autoreconf takes a
> bit more time to run than the individual tools, but it's worth it for
> the simplicity.
> 
> So, add a list of directories for which it is known that they can be
> re-generated using a simple autoreconf without special flags.  For these
> directories, call `autoreconf -f`.

Very nice, now running this regenerates the binutils-gdb files exactly
as they are checked in. Also tested on the gcc tree, which also works
fine.

Applied (with small adjustments for the previous two patches).

Thanks,

Mark