From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (gnu.wildebeest.org [45.83.234.184]) by sourceware.org (Postfix) with ESMTPS id 155163857B86 for ; Fri, 15 Mar 2024 10:06:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 155163857B86 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 155163857B86 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=45.83.234.184 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710497178; cv=none; b=xPIsAZBP3oL5RSJBv/bbrs4E/7+plDu9yW7q4OCSozzz0aqorAm7MT6jhDD6fMHc66iaUQmveVNBEzng85cxTc4vKNjU4wp+krC2M/+IKSeW7Wtvf2HGWeu+enbRaZWGQm8OlNsJe5FJEada6tGeTzgCK0s/mEkhYk19TagSFIw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710497178; c=relaxed/simple; bh=PW5BBGL2mn5ZYR6n9vYdjY3rQGsDzuC9Nv7RvlVLmx8=; h=Date:From:To:Subject:Message-ID:MIME-Version; b=ko8NyWBQE0Pl3QScJH9oKAV2wcrj+Txsm2n/xZvNaalOXfQnm59gs+l0bHLGHwSQuY8y3swyPFTDVS32opc5u7cYIAITbgKJ4IaPcns7jXDj//qoXn61HkhbLTQYjcmM1wAWRHUmFk101u9AW5tLvUgRb7HX6d/V4iagUfO172k= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by gnu.wildebeest.org (Postfix, from userid 1000) id 0CC083000472; Fri, 15 Mar 2024 11:06:15 +0100 (CET) Date: Fri, 15 Mar 2024 11:06:15 +0100 From: Mark Wielaard To: YunQiang Su Cc: David Malcolm , Patrick Palka , gcc-patches , buildbot@sourceware.org Subject: Re: CI for "Option handling: add documentation URLs" Message-ID: <20240315100615.GT30331@gnu.wildebeest.org> References: <2fb7351ea8964914836415cf6cd36c0474cc6a33.camel@redhat.com> <20240218225810.GH16832@gnu.wildebeest.org> <20240224174258.GD1353@gnu.wildebeest.org> <20240303200447.GJ13156@gnu.wildebeest.org> <20240305202418.GA24213@gnu.wildebeest.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi YunQiang Su, On Fri, Mar 15, 2024 at 03:33:28PM +0800, YunQiang Su wrote: > Great work. The CI works well now: it blames me ;) > https://builder.sourceware.org/buildbot/#/builders/269/builds/3846 > > When I add '-mstrict-align' option to MIPS, > the riscv.opt.urls, sysv4.opt.urls, xtensa.opt.urls are changed also. > (why they are effected? They are effected because they also have a '-mstrict-align' option and each option with the same name gets an unique number. > So what's the best practice for this cases? > Should I push a new commit? Or in fact a single commit is preferred? I don't know if there is a rule for this. But I hope this falls under the obvious rule. What I would do is simply take that diff the CI produced. https://builder.sourceware.org/buildbot/api/v2/logs/7798308/raw Apply it and commit that with: Regenerate opt.urls Fixes: acc38ff59976 ("MIPS: Add -m(no-)strict-align option") gcc/ChangeLog: * config/riscv/riscv.opt.urls: Regenerated. * config/rs6000/sysv4.opt.urls: Likewise. * config/xtensa/xtensa.opt.urls: Likewise. Cheers, Mark