From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (gnu.wildebeest.org [45.83.234.184]) by sourceware.org (Postfix) with ESMTPS id 074E13858D34 for ; Sun, 14 Apr 2024 22:33:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 074E13858D34 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 074E13858D34 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=45.83.234.184 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713134062; cv=none; b=aB9HFG0go8RmLBwj7Nbfjgy1wLjfSFvyloCAgvEipxoaTWaBO3B36/mXvi6OIB5aHACi3sY0fT72+wDexaJIExy4brg89+40K1Hbe8MJhbJjUy4VsIp4QdZJesV8djsOW59fDZCRipwRd9bTCjWZl8jEdJClSZdzAQa0iMPHftg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713134062; c=relaxed/simple; bh=0dMbs4+zZUTUZpmuxrrdVi0a4DACwpsPFrBpvEFm8r0=; h=Date:From:To:Subject:Message-ID:MIME-Version; b=MYzy/9UTHfnSwuQUZivv584zrHxHd7yEsqEQOdjXkYk5Bsz7qUvpOIyXoYFpYo9r1yxnnfiDo5wsquz9EJqyJRCvMRfDLDhAeXWFG3GFY7QIHX5RelUNXFs5RVX3uSB1ymG91AbJWMDSX7pmMWGVB5OiEpSrg/Gf9S3F/IZcnos= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by gnu.wildebeest.org (Postfix, from userid 1000) id 1F2E63000587; Mon, 15 Apr 2024 00:33:43 +0200 (CEST) Date: Mon, 15 Apr 2024 00:33:43 +0200 From: Mark Wielaard To: Christophe Lyon Cc: buildbot@sourceware.org Subject: Re: [PATCH 0/6] autoregen.py: Improve support for GCC Message-ID: <20240414223343.GT1292@gnu.wildebeest.org> References: <20240412200559.1649050-1-christophe.lyon@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240412200559.1649050-1-christophe.lyon@linaro.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Christophe, On Fri, Apr 12, 2024 at 08:05:53PM +0000, Christophe Lyon wrote: > I looked into more details to improve autoregen.py's support for GCC. > > I noticed that autoreconf works well in most directories, so this > patch series adds most GCC subdirs to AUTORECONF_DIRS. Nice, that simplifies things. > Following that, I noticed that quite a few more subdirs from > binutils-gdb can also be regenerated using autoreconf, so add them to > AUTORECONF_DIRS. Ack. > In addition, add support for autogen, to regenerate the top-level > Makefile.in. I added autogen to the Containerfile-autotools to make sure it is available. I assume the version doesn't matter. > There are still some peculiarities with some subdirs, so there are > probably some fixes to make in binutils, gdb and gcc. We can update > this script when that is the case. > > Also, this script should probably be copied into contrib/ for the > benefit of the projects. Yes, that would be good. Do binutils-gdb/gcc share a contrib dir? We could pick up the script from there, we don't necessary need to have it in the builder.git itself. > Christophe Lyon (6): > auroregen.py: Check AC_CONFIG_MACRO_DIR instead of > AC_CONFIG_MACRO_DIRS > autoregen.py: Move comment... > autoregen.py: Flush all print commands > autoregen.py: Use autoreconf in most GCC directories > autoregen.py: Add support for autogen > autoregen.py: Add binutils directories to AUTORECONF_DIRS Applied all of them. Thanks, Mark