From: Mark Wielaard <mark@klomp.org>
To: Marc <dkm@kataplop.net>
Cc: buildbot@sourceware.org
Subject: Re: [PATCH] Install recent rustc in Debian stable
Date: Tue, 27 Aug 2024 11:36:47 +0200 [thread overview]
Message-ID: <20240827093647.GE16680@gnu.wildebeest.org> (raw)
In-Reply-To: <87zfoy8mtz.fsf@kataplop.net>
Hi Marc,
On Tue, Aug 27, 2024 at 09:08:24AM +0200, Marc wrote:
> Marc Poulhiès <dkm@kataplop.net> writes:
>
> > +# Rust from Debian stable is too old to build the small dependencies of GCCRS
> > +# The project currently use 1.72.0, so install and use the same.
> > +RUN (curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y --default-toolchain=1.72.0 --no-modify-path)
>
> "someone" already raised a possible issue with this curl|sh install
> method.
It might just be a "feeling", we do trust the distro image and package
repositories after all. But just piping a shell script from a website
into the shell does feel a little iffy.
> I don't have strong feeling about that. I can also download the shell
> script and execute it. Or follow another install method.
The script seems to mainly be to detect which architecture/distro you
are running and which tools are installed to download another
downloader binary rust-init. It then tries to execute this binary to
download other binaries (cargo, clippy, rust-docs, rust-std, rustc and
rustfmt).
Since we are after a specific version, could we try to fetch that one directly?
https://static.rust-lang.org/rustup/archive/1.27.1/x86_64-unknown-linux-gnu/rustup-init
And then check against the expected sha256sum?
Then at least we know we got the "correct" downloader.
> FWIW, it's the recommended way of using rustup:
>
> https://rustup.rs/
>
> Let me know if you'd prefer I change this.
Let me know what you think of the above. Paranoid?
Also, maybe we should create a new container, just for a full gcc
(with rust) builder to keep the default Debian container smaller (we
can then also drop gdc and gnat).
> Also, I recalled that there's already a gccrust builder, so there must
> be a container with a recent enough rustc: maybe the gcc-all could use
> the same container? I didn't find the info last night.
There are a couple of container and non-container builders that try to
build gccrust (non-gcc-tree):
https://builder.sourceware.org/buildbot/#/builders?tags=gccrust
Most currently fail because they don't have a recent cargo installed.
Lets look at those (and switch them to the gcc tree?) after we got
this debian container build going.
Cheers,
Mark
next prev parent reply other threads:[~2024-08-27 9:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-26 20:56 Marc Poulhiès
2024-08-27 7:08 ` Marc
2024-08-27 9:36 ` Mark Wielaard [this message]
2024-08-28 8:02 ` [PATCH v2] " Marc Poulhiès
2024-09-01 15:33 ` Mark Wielaard
2024-08-28 11:05 ` [PATCH] " Frank Ch. Eigler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240827093647.GE16680@gnu.wildebeest.org \
--to=mark@klomp.org \
--cc=buildbot@sourceware.org \
--cc=dkm@kataplop.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).