From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id AF2F6385828A for ; Sun, 19 Jun 2022 07:12:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org AF2F6385828A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.cz Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id C2F791F97A; Sun, 19 Jun 2022 07:12:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1655622732; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TT3FVcwnVyChxxbG0QPb1AY4z4cnvcBDb6Fbz9NSJaI=; b=E988Pfh2igAaTsHS2S4S+uplB51fMvVD3lwcHGUUdR6EyEx7nDb8Iu3ZAMUGzz6h/W8fj+ SsWPAHb6e3SXyuaOuZSe4ofmAxsSt99/6xHWaIBtuYcQNAvbQe7fmI/o8teCZTmZ/rhhfG qFSN77eauL4MPESOn9t1FmBexIt8SzA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1655622732; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TT3FVcwnVyChxxbG0QPb1AY4z4cnvcBDb6Fbz9NSJaI=; b=y6okPA/6pbpkpluv5k0o+S1EHatIqhkJYRQ7iEJSG6snBQjSbdOexBuplrwnBiGILYRktR D0DBvsVF0qbmeaCQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id ADDE813427; Sun, 19 Jun 2022 07:12:12 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id KXeHKUzMrmL9YgAAMHmgww (envelope-from ); Sun, 19 Jun 2022 07:12:12 +0000 Message-ID: <2c76b4a2-861e-159b-2239-8ae54d5ea114@suse.cz> Date: Sun, 19 Jun 2022 09:12:12 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [RFC,PATCH] containers: extract bb-start.sh to a file and reuse it Content-Language: en-US To: Mark Wielaard Cc: buildbot@sourceware.org References: <90c38f7f-0244-fc5d-85a5-8adab72023a9@suse.cz> From: =?UTF-8?Q?Martin_Li=c5=a1ka?= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: buildbot@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "The https://builder.sourceware.org/ buildbot" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Jun 2022 07:12:15 -0000 On 6/18/22 22:11, Mark Wielaard wrote: > Hi Martin, > > On Sat, Jun 18, 2022 at 08:35:06PM +0200, Martin Liška wrote: >>> I like this. But we cannot simply COPY in the bb-start.sh file. >>> Because it isn't available on the container host. The >>> DockerLatentWorker only sents the Container file. But we could fetch >>> it from the git repo using: >>> >>> RUN wget -O /home/builder/bb-start.sh \ >>> 'https://sourceware.org/git/?p=builder.git;a=blob_plain;f=builder/containers/bb-start.sh' \ >>> && chmod 755 /home/builder/bb-start.sh >> >> Good, I've done that and pushed to main. >> >> However, I see an error now: >> https://builder.sourceware.org/buildbot/#/builders/97/builds/248 >> >> Can you please check buildbot master log files in order to investigate what's wrong? > > The issue was that there were now both a RUN wget && chmod and a COPY > in the Container files. Removing the COPY seems to have made it work again. Oh, what a stupid mistake I've made. Thanks for the fix! Martin > > Cheers, > > Mark