Re: [RFC,PATCH] containers: extract bb-start.sh to a file and reuse it

["Martin Liška" <mliska@suse.cz>]

On 6/18/22 17:47, Mark Wielaard wrote:
> Hi Martin,
> 
> On Fri, Jun 17, 2022 at 11:17:28AM +0200, Martin Liška wrote:
>> Doing echo "..." > bb-start.sh adds one more level of escaping
>> and it is quite ugly. Use rather a proper file and discard all
>> the Debian switch to bash and back.
>>
>> Mark can you please test it if it works with the newly set 2 ENV variables:
>> ENV IMAGE_NAME=debian-stable
>> ENV CCACHE_LIBDIR=/usr/lib/ccache
> 
> I like this. But we cannot simply COPY in the bb-start.sh file.
> Because it isn't available on the container host. The
> DockerLatentWorker only sents the Container file. But we could fetch
> it from the git repo using:
> 
> RUN wget -O /home/builder/bb-start.sh \
>     'https://sourceware.org/git/?p=builder.git;a=blob_plain;f=builder/containers/bb-start.sh' \
>     && chmod 755 /home/builder/bb-start.sh

Good, I've done that and pushed to main.

However, I see an error now:
https://builder.sourceware.org/buildbot/#/builders/97/builds/248

Can you please check buildbot master log files in order to investigate what's wrong?

Thanks,
Martin

> 
> We could also git clone the whole builder.git repo and then copy the
> bb-start.sh file from the checkout, but this seems simpler.
> 
> If this works for you, please commit.
> 
> Thanks,
> 
> Mark