From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id 1AC3838582AC for ; Sat, 18 Jun 2022 18:35:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1AC3838582AC Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.cz Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 507AB21BD8; Sat, 18 Jun 2022 18:35:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1655577308; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2uXhRFny7hNDPRZpYCW10wHtoXP78NgBgCDv+rDc4tU=; b=0uUBL/qGgekF0Q9l/ycJdsuv7OKezGo9Ay3/W7LlVpb1Ht/GdEYdJQuQ3a8qkJqq9AEVMM Ph5ZUkJnwTZLP2tPHkpxMW+YYYi+Eoi3yjJfqXu8vmEbwvpVhppW1jMWnoR2zQx9iKOcyI GjFnjo+yXVhFP00t4QPAovIjVOKRfRk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1655577308; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2uXhRFny7hNDPRZpYCW10wHtoXP78NgBgCDv+rDc4tU=; b=mBM1/iV3r64YXfryi2y/SvICD3RMajU0iy1v9Ed0WZzbGoweFgCqDtc0DixD3Ksmmntskh 661+zGHDZHeMsCAg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 3E34F1342C; Sat, 18 Jun 2022 18:35:08 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id swctDtwarmK1KQAAMHmgww (envelope-from ); Sat, 18 Jun 2022 18:35:08 +0000 Message-ID: <90c38f7f-0244-fc5d-85a5-8adab72023a9@suse.cz> Date: Sat, 18 Jun 2022 20:35:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [RFC,PATCH] containers: extract bb-start.sh to a file and reuse it Content-Language: en-US To: Mark Wielaard Cc: buildbot@sourceware.org References: From: =?UTF-8?Q?Martin_Li=c5=a1ka?= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: buildbot@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "The https://builder.sourceware.org/ buildbot" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 18 Jun 2022 18:35:10 -0000 On 6/18/22 17:47, Mark Wielaard wrote: > Hi Martin, > > On Fri, Jun 17, 2022 at 11:17:28AM +0200, Martin Liška wrote: >> Doing echo "..." > bb-start.sh adds one more level of escaping >> and it is quite ugly. Use rather a proper file and discard all >> the Debian switch to bash and back. >> >> Mark can you please test it if it works with the newly set 2 ENV variables: >> ENV IMAGE_NAME=debian-stable >> ENV CCACHE_LIBDIR=/usr/lib/ccache > > I like this. But we cannot simply COPY in the bb-start.sh file. > Because it isn't available on the container host. The > DockerLatentWorker only sents the Container file. But we could fetch > it from the git repo using: > > RUN wget -O /home/builder/bb-start.sh \ > 'https://sourceware.org/git/?p=builder.git;a=blob_plain;f=builder/containers/bb-start.sh' \ > && chmod 755 /home/builder/bb-start.sh Good, I've done that and pushed to main. However, I see an error now: https://builder.sourceware.org/buildbot/#/builders/97/builds/248 Can you please check buildbot master log files in order to investigate what's wrong? Thanks, Martin > > We could also git clone the whole builder.git repo and then copy the > bb-start.sh file from the checkout, but this seems simpler. > > If this works for you, please commit. > > Thanks, > > Mark