From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [IPv6:2a00:1450:4864:20::52d]) by sourceware.org (Postfix) with ESMTPS id 623793858D32 for ; Mon, 15 Apr 2024 12:56:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 623793858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 623793858D32 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::52d ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713185772; cv=none; b=esy//fbZ618sw9Ocx3wc7x3uWB1QCst2j0ztmv0dzgj9SHWrCebgYf5tzE1LvWNvaLb0p9+B/shklH4fQj9B6ykmVvtvFEayjPnchlinsE4WVfAZFCeVxdk6WR9VdF5XuHXvqjXPVerKHv9pKnZTf7b8HHnG/9UZ7bJt7JyiLmk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713185772; c=relaxed/simple; bh=QsCTVV7PMafqwqO3WjtsyTtJBKkJSMAFFZIrVSln+8o=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=ICQav83Q6RlbkGKqdBNldfWvyBQB1qu441Ek58+PssoqPlqG54hd7Y0iFQZD4Y8jtZ75oWkVIsAS2+FB4Zlb+5ERQN453tZ0Lk9AAr9DjvHnvLGYBCWLTXNJZrqYrNn9ifDQuRb8VFpHtajtcWjM7fQh56FrY46uGXcBaOZwf+o= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ed1-x52d.google.com with SMTP id 4fb4d7f45d1cf-565c6cf4819so6883741a12.1 for ; Mon, 15 Apr 2024 05:56:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1713185769; x=1713790569; darn=sourceware.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=+4xH9Yz+ZvbE+jtGh05KPSndFjenqCQt63DpamyO0u0=; b=erUCoQPdkIStQbKzJhDwmBZJOAmI2Ypr7NfwucWKLnONW9W/fHhqdFEEpkB0vw1LA5 VXzJfOXzbZlgMgfo0kgBfqE1kWkvutGxZlsnR1KAwlisVNuP0bI6yLQlHQK1IFGV31+u kOm54QaqpgY2CHqPoN92xBXGXdassLnKjJjaxLsdhCwze7uLdYNGLtYTvC/DsD4vJA05 xT3wgZIwZscNs9m/tnbjw0hP+xg+p8Wl45Zhe8fVI894FngM3a2CFrY9rORvVaP2n4Il Dt7tSQnWond2QZnGLT80k+c+gsvSVdsZAavU7oNzyLNYzEkcCkZFLcyNhK7kfevNvjhW pqCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713185769; x=1713790569; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+4xH9Yz+ZvbE+jtGh05KPSndFjenqCQt63DpamyO0u0=; b=MWR63obZzV8ONXFZQXkh9zliHjQP1pvarhnT0Da2c7ZytgU1gb6b6ASulnm6uT7NPy Goio4kq+N7TSw1ah9cxagMjjfRcZML+WbP/jxW/ZcN3lkSvzZGoqIktEObw+nAsI7kay +x1Qfq02iZDVtNaCQgSmKITMsTn+iNBm6W9pjVQWHQkQv3rsE3tF6OqZr4V8Jp150QEG uuxJjOz0kQ8HOUgYzobSOSl4g8/qswmLU5klQjExO/rKDA1Ht9LazPYOjmQU53BUVv3c /EieVhKQhowRpS8zaTI1/g2zoU5nDDoYDtVwgG0eBaGewYsyxAte3Nxwd858e+vllsGS +PGA== X-Gm-Message-State: AOJu0YxTZU7QjoZrIKrwMJZboAThK9m1q8SVoutzJqRPa4zghesdbgNa jN9xGOADTBbSek5esqmtxeikfKSYUPmkGgofMkv4lvghFHNlcq99S3q7ebl6d+QED2vfDxvp7ea OQuF8xy6VJlWKhJoZ3XA439283M5/dMLW5sfukBiot6VmfeXvO/o= X-Google-Smtp-Source: AGHT+IHUD8viUIUMVwyhkZleLMfZdnYXUwtLo8aWuQAzM/25uQsTqsRPbN1klQEvXvm2ZQSoCsf66m/Niu5JL85PglI= X-Received: by 2002:a17:907:6d18:b0:a52:11c8:764e with SMTP id sa24-20020a1709076d1800b00a5211c8764emr10001916ejc.25.1713185769127; Mon, 15 Apr 2024 05:56:09 -0700 (PDT) MIME-Version: 1.0 References: <20240412200559.1649050-1-christophe.lyon@linaro.org> <20240412200559.1649050-5-christophe.lyon@linaro.org> In-Reply-To: From: Christophe Lyon Date: Mon, 15 Apr 2024 14:56:03 +0200 Message-ID: Subject: Re: [PATCH 4/6] autoregen.py: Use autoreconf in most GCC directories To: Mark Wielaard Cc: buildbot@sourceware.org, Thomas Schwinge , Ian Lance Taylor , Jakub Jelinek Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-10.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, 15 Apr 2024 at 14:46, Mark Wielaard wrote: > > Hi (adding Jakub and Ian to CC), > > On Mon, 2024-04-15 at 13:42 +0200, Mark Wielaard wrote: > > On Fri, 2024-04-12 at 20:05 +0000, Christophe Lyon wrote: > > > Add most of GCC's subdirectories to AUTORECONF_DIRS, since 'autoreconf > > > -f' works for them. > > > [...] > > > # these directories are known to can be re-generatable with a simple autoreconf > > > # without special -I flags > > > AUTORECONF_DIRS = [ > > > + # binutils-gdb subdirs > > > "gdb", > > > "gdbserver", > > > "gdbsupport", > > > "gnulib", > > > + > > > + # gcc subdirs > > > + "c++tools", # No aclocal.m4 > > > + #"gcc", # No Makefile.am > > > + #"fixincludes", # autoreconf complains about GCC_AC_FUNC_MMAP_BLACKLIST > > > + "gnattools", # No aclocal.m4 > > > + "gotools", > > > > Oddly this now generates: > > https://builder.sourceware.org/buildbot/#/builders/269/builds/4325 > > > > Entering directory /home/builder/shared/bb3/worker/gcc- > > autoregen/build/gnattools > > + autoreconf-2.69 -f > > > > [... where before it was just autoconf-2.69 -f ...] > > > > diff --git a/gotools/Makefile.in b/gotools/Makefile.in > > index 36c2ec2abd3..f40883c39be 100644 > > --- a/gotools/Makefile.in > > +++ b/gotools/Makefile.in > > @@ -704,8 +704,8 @@ distclean-generic: > > maintainer-clean-generic: > > @echo "This command is intended for maintainers to use" > > @echo "it deletes files that may require special tools to > > rebuild." > > -@NATIVE_FALSE@install-exec-local: > > @NATIVE_FALSE@uninstall-local: > > +@NATIVE_FALSE@install-exec-local: > > clean: clean-am > > > > clean-am: clean-binPROGRAMS clean-generic clean-noinstPROGRAMS \ > > > > This started with: > > https://gcc.gnu.org/cgit/gcc/commit/?id=f7c8fa7280c85cbdea45be9c09f36123ff16a78a > > > > Inline 'gcc/rust/Make-lang.in:RUST_LDFLAGS' into single user > > gcc/rust/ > > * Make-lang.in (RUST_LDFLAGS): Inline into single user. > > > > Which doesn't really make sense, since that doesn't touch gotools at > > all... > > > > I am not sure why. > > Looks like this is just random/non-deterministic. > Jakub has a patch here: > https://inbox.sourceware.org/gcc-patches/Zh0grrP%2FMPu3pXbC@tucnak/T/#u > Ha! Thanks for looking at this, I had noticed a problem a while back when working on autoregen.py but couldn't reproduce it anymore lately. Thanks, Christophe > Cheers, > > Mark >