From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [IPv6:2a00:1450:4864:20::633]) by sourceware.org (Postfix) with ESMTPS id E802C3858C41 for ; Mon, 15 Apr 2024 11:52:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E802C3858C41 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E802C3858C41 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::633 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713181976; cv=none; b=JqhQMaNDWw+uX+JWYT/PNJs12Q0Qf5vPhK+nd+KyuLoiG5JApz6WyMBUncylP1zXyVRJOlo4c6V+AepazOg+FdDlRSUo+eXEw0ZT6uVqizXq7V5Mqk7by/KeyTDBOpq4Aac6+S3JPYF3EpcQDCKRHGrxfez5WWY2tG90kE2f9FI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713181976; c=relaxed/simple; bh=1eikYjIujTkwJ3U32GckNUfBz9cnmzkdKVXwaPj3of4=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=xyPqTOzSaDP1CdmbFkTKrxOgjfn/H6ZwUu5Es6QD+JeLy6OvKhVMkuq/oVRMFQ/G1jLTQX//rV1WV/RHj1fEJU4o0raYL5KPDKPY/LEgOrTVn+FUY+ptzkKKv1WxPaoavcAlgdTgxUT7jh2K57jUk6vfYmTELExQ7t04dw1H+KI= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ej1-x633.google.com with SMTP id a640c23a62f3a-a5224dfa9adso491439366b.0 for ; Mon, 15 Apr 2024 04:52:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1713181972; x=1713786772; darn=sourceware.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=2CKXpJdulmeBcsQO0aXBM4mjw+wazT64HYmKbe8OGus=; b=RlIHbDMepJcYAd3IpkbmbKcWPCwVNGBVh5nMLNaLYRTVkmgKjTyF0LH40Aan5GVymP isDKFHcG8IRMKECRZitQXBJkNWMFpnV/wJ429xAie4KCTISOIkMBL3W0VRFJVnMrYjfO MydAWKJZ4di9y32kLGMIgQSs5GYI0gOSEgUTTJL8NySqmd9BLXj+ZUVXBp8kyEYSTVZc ai9vhPUZ8HiGbjgtNloca12L6JwnluTb2BZ6wwhe5sp3EdpeKfgC3z3ghWiuYL+/yIGR V8t6snSqcGR/IUzy2eHt6kh1QFjvdemuITroLWrDSpea3hyLfLlZsIshry9pRHsVKuGu bgvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713181972; x=1713786772; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=2CKXpJdulmeBcsQO0aXBM4mjw+wazT64HYmKbe8OGus=; b=SpUYmDsF4fZhIX6YQDT0fCU3SBmklNOzcPHaGg4KbXUCUkkieI0VcwaIPJXSOVWbfp DSWkc2ORjC384FgAWyNImWhCs6qfYij3iFaAqlC9ggz7jRro2nvVKdEQ5HC4I3RlfBRY DoX6A4CQmwGMqbpj4Cl/7xjKSlT2ryDopu5xbT0PnCsjAvckSFLFTo+9JRfBXPzwxxzp oob/hVd1IQPni46EJyjcLRKK1iurF8qp3S0Mgsm4VHIvIkY9U0VRNOOZ49uTWHFOi2bc GLL0JsB3THyW04lT1TPPxy++JjibiZTp4JkPWAjU9a+jGsH8nmzoag2dtazSjkCieER6 DusQ== X-Gm-Message-State: AOJu0YxajHkQRqUscMj2NiZ8pqylhL6swoumzLdGSWIPgwq/QPZVAJBI Ku2DahrKnEd++y6rexe7J1IJxLKEAMz3ph/oHrfrPFRlZK7aJg+sFA0vyYW4aeQ9/C/FbGDr2Bu XGmZlvzca4bvaVdNJGI5iQmhM1Y3Cba/p5xVWYxit5MFtIqMXQjA= X-Google-Smtp-Source: AGHT+IH2/IVYmCw7Bed0ubJKN9HBO8ZdD2ZbcqzciO/I8CZaVZAZTCp+U3XAj4SOBeQE4+63e/wYOpc1d2p46VmzwUU= X-Received: by 2002:a17:906:f2cb:b0:a52:5b0f:7f99 with SMTP id gz11-20020a170906f2cb00b00a525b0f7f99mr3330771ejb.6.1713181972533; Mon, 15 Apr 2024 04:52:52 -0700 (PDT) MIME-Version: 1.0 References: <20240412200559.1649050-1-christophe.lyon@linaro.org> <20240414223343.GT1292@gnu.wildebeest.org> In-Reply-To: <20240414223343.GT1292@gnu.wildebeest.org> From: Christophe Lyon Date: Mon, 15 Apr 2024 13:52:46 +0200 Message-ID: Subject: Re: [PATCH 0/6] autoregen.py: Improve support for GCC To: Mark Wielaard Cc: buildbot@sourceware.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, 15 Apr 2024 at 00:33, Mark Wielaard wrote: > > Hi Christophe, > > On Fri, Apr 12, 2024 at 08:05:53PM +0000, Christophe Lyon wrote: > > I looked into more details to improve autoregen.py's support for GCC. > > > > I noticed that autoreconf works well in most directories, so this > > patch series adds most GCC subdirs to AUTORECONF_DIRS. > > Nice, that simplifies things. > > > Following that, I noticed that quite a few more subdirs from > > binutils-gdb can also be regenerated using autoreconf, so add them to > > AUTORECONF_DIRS. > > Ack. > > > In addition, add support for autogen, to regenerate the top-level > > Makefile.in. > > I added autogen to the Containerfile-autotools to make sure it is > available. I assume the version doesn't matter. I did not see any mention of a version number in the generated files, so I assumed it doesn't matter. > > > There are still some peculiarities with some subdirs, so there are > > probably some fixes to make in binutils, gdb and gcc. We can update > > this script when that is the case. > > > > Also, this script should probably be copied into contrib/ for the > > benefit of the projects. > > Yes, that would be good. Do binutils-gdb/gcc share a contrib dir? > We could pick up the script from there, we don't necessary need to > have it in the builder.git itself. There's a contrib dir in both binutils-gdb and gcc, though gcc's has many more utilities. dg-extraact-results.{py,sh} have the same contents, while mklog.py is not the same in the two repos: the version in binutils-gdb wasn't updated since it was first copied from the gcc repo. I suspect the same sync issue would/will happen with autoregen.py, but still I think it would help developers of both projects to have it in contrib rather than in builder.git (which I think most people don't know about). > > > Christophe Lyon (6): > > auroregen.py: Check AC_CONFIG_MACRO_DIR instead of > > AC_CONFIG_MACRO_DIRS > > autoregen.py: Move comment... > > autoregen.py: Flush all print commands > > autoregen.py: Use autoreconf in most GCC directories > > autoregen.py: Add support for autogen > > autoregen.py: Add binutils directories to AUTORECONF_DIRS > > Applied all of them. > Thanks! Christophe > Thanks, > > Mark