From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [IPv6:2a00:1450:4864:20::535]) by sourceware.org (Postfix) with ESMTPS id 01C8F3858D32 for ; Mon, 15 Apr 2024 11:55:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 01C8F3858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 01C8F3858D32 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::535 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713182138; cv=none; b=RVwpLcmM+OmvvTD4XRRSrYmGsb909nicHvHAVvWhU2be9MPAS3kY4mW4RUEmNMK4Sm+JvfVGPqChwhYuox6njPyEp0tXRfz7wCVydOvg4/fdV6iinOJ74v3ksucpKL/rs9xF2u3u6sRul56qz2+5Z0qLATgKwlcFqZmhl4MWzWE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713182138; c=relaxed/simple; bh=lUKqPZZG/SzrVF69sF6wvO0d1uiHNghsfQMvgte4QnY=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=eUK9NBDTkaiZVBvjseyD8nZQva3ls+fftUnqitaiHi+v2SSNkApd3TPD798kZNoG4YcJ6zPRac0uw3ftPeOZjwNW7zfsWZxR5paoNVyu7Rr+JPeMeBkvIzjZUXDSRXhtoOKMtVmf23Edws+M23RhhqJdDcpVQ7O7+OwET0mq67U= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ed1-x535.google.com with SMTP id 4fb4d7f45d1cf-570097653faso1513994a12.0 for ; Mon, 15 Apr 2024 04:55:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1713182136; x=1713786936; darn=sourceware.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=PQ/noetA7oEt1amX8LJ8y66Suq6weuyDeokF7BDRTHY=; b=SEycIT/BJaLBq0i8l6h9D/KRqR8nt2Ps3mCe3+9296xvifz3ch2J3MDK61TsL5tvCh O1PN3ut4DH63xldsAyNaB+TFow6v/zD0DGdUuJScl/f//xPjqHKGxcdVNsui7zQrWTbk xnnK+Hod8FlCWblKYkLqzt59Hq02m0ebPag30yQ1DmyCz9X/fPBNKMzTDfwClHNWbtgM wsJvqCMWJvRKstj2o4hirRwHkLbVNYbRbTFdaG7+sI0LikUfFyw6BFVgvoq1R3HvLRJb NCBxFl3Mw52mp9r0phKNPr7PF9aOWYz1bpegQOBA9lulkRWvUSDXTDMoABWvTX+M7cQ9 36Lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713182136; x=1713786936; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=PQ/noetA7oEt1amX8LJ8y66Suq6weuyDeokF7BDRTHY=; b=GRDxNk4Z2Q6rx5Fr1rl8W5y143tw5BvHcQPZP5rTp+hPap+smG9ViAxbK0spo5YI/2 9g9T31h/rD8dXCnPuVws0gFf82zKNAMrFn3bu23u5PgUIGACkQJQ3OoXoEj2S6o43Kwk puxUnIkhkfQLNZ5Cu+e4DJbJiutmCDtHgkgsWA4CJmrEoygE/UuEFCmrOMeAGRpudYjC KOF/cBCtEJRelEErl+kWetcf+FyAwMGt6TV8z/s3gHzrIi/g6Qx08/7tyYRQhTaj5AwF CLP1bKszyecOMkscDBg6xKkm5B7lYwkPOLo4xwqwBhRQECpzfu5XU9aa26nfPOWlUT5T KxMQ== X-Gm-Message-State: AOJu0YzvgHdgQP5pV0BM5oP9tEVIZ/+ITsLRXxYgwH4/L+ffEJs20TK6 BsKpPoMAMbUWbvc+zcgDULmVwVxxcd2nfuNqPv/vLqZT7XbKDuTVqfIgZ2X0F1AoswIyNbmEZeA jbt+QajxIP38YDjB/XDjyubA0Yrcl+VQRHlhymbzoA12IkUdxYmc= X-Google-Smtp-Source: AGHT+IHb2OV2LbjRmkXkKc66HC65U+sUkleP5ObDfYxyHs9zJzTdviB1eIg06+euECekQXRxu1fYClRSjJQtwRfd7b0= X-Received: by 2002:a50:a695:0:b0:570:35e:9a09 with SMTP id e21-20020a50a695000000b00570035e9a09mr6600205edc.7.1713182135733; Mon, 15 Apr 2024 04:55:35 -0700 (PDT) MIME-Version: 1.0 References: <20240412200559.1649050-1-christophe.lyon@linaro.org> <20240412200559.1649050-4-christophe.lyon@linaro.org> <1aedfffb-f027-474c-af36-d9053cb9a078@simark.ca> In-Reply-To: <1aedfffb-f027-474c-af36-d9053cb9a078@simark.ca> From: Christophe Lyon Date: Mon, 15 Apr 2024 13:55:30 +0200 Message-ID: Subject: Re: [PATCH 3/6] autoregen.py: Flush all print commands To: Simon Marchi Cc: buildbot@sourceware.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-10.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, 15 Apr 2024 at 04:09, Simon Marchi wrote: > > > > On 2024-04-12 16:05, Christophe Lyon wrote: > > For consistency and easier debug of traces > > --- > > builder/containers/autoregen.py | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/builder/containers/autoregen.py b/builder/containers/autoregen.py > > index 6e341e2..c52a524 100755 > > --- a/builder/containers/autoregen.py > > +++ b/builder/containers/autoregen.py > > @@ -56,7 +56,7 @@ AUTORECONF_DIRS = [ > > # > > # Print the command on stdout prior to running it. > > def run_shell(cmd: str): > > - print(f"+ {cmd}") > > + print(f"+ {cmd}", flush=True) > > res = subprocess.run( > > f"{cmd}", > > shell=True, > > @@ -105,7 +105,7 @@ run_shell(f"{AUTOMAKE_BIN} --version") > > run_shell(f"{ACLOCAL_BIN} --version") > > run_shell(f"{AUTOHEADER_BIN} --version") > > > > -print(f"Extra environment: {EXTRA_ENV}") > > +print(f"Extra environment: {EXTRA_ENV}", flush=True) > > > > config_folders: list[Path] = [] > > repo_root = Path.cwd() > > Can you clarify when/where/why that's needed? I would expect the stdout > stream to be flushed when there is an end-of-line (which print() does). > I'm not quite sure now.... I think I was annoyed when looking at builds in progress on the sourceware buildbot. > Simon