From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (gnu.wildebeest.org [45.83.234.184]) by sourceware.org (Postfix) with ESMTPS id 77B6238582A1 for ; Wed, 23 Nov 2022 00:37:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 77B6238582A1 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org Received: from reform (deer0x0e.wildebeest.org [172.31.17.144]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 74D0830008BB; Wed, 23 Nov 2022 01:37:13 +0100 (CET) Received: by reform (Postfix, from userid 1000) id 37E442E83A66; Wed, 23 Nov 2022 01:37:13 +0100 (CET) Date: Wed, 23 Nov 2022 01:37:13 +0100 From: Mark Wielaard To: Arsen =?utf-8?Q?Arsenovi=C4=87?= Cc: buildbot@sourceware.org, poke-devel@gnu.org Subject: Re: [PATCH builder.git] master.cfg: add GNU poke builder Message-ID: References: <20221119233644.911898-1-arsen@aarsen.me> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20221119233644.911898-1-arsen@aarsen.me> X-Spam-Status: No, score=-3038.7 required=5.0 tests=BAYES_00,GIT_PATCH_0,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Arsen, On Sun, Nov 20, 2022 at 12:36:45AM +0100, Arsen Arsenović via Buildbot wrote: > - What distros and CPUs do we want to test on? > > I think at least s390x in conjunction with x86_64 would be useful, to provide > a reference for big endian machines, to detect if we're accidentally relying > on endianness. > > It would probably be useful to test on Debian stable+testing and Fedora > latest+rawhide, just to make sure we work in both in the past and in the > future; though, it's probably less significant than CPU choices. > > I only left debian-testing in in the current revision of the patch, which has > UNSUPPORTED tests due to libtextstyle. So for now lets only use debian-testing to see how things go. BTW. I tried on debian-i386, but got some test failures/crashes: The following patch seems to fix that: diff --git a/libpoke/pkl-lex.l b/libpoke/pkl-lex.l index 4c9b013e..ef562ccb 100644 --- a/libpoke/pkl-lex.l +++ b/libpoke/pkl-lex.l @@ -176,7 +176,7 @@ build_overflow_error_msg (uint64_t value, int width) : ""); asprintf (&msg, - "signed overflow\ntry: %luU%s as int<%d>", + "signed overflow\ntry: %" PRIu64 "U%s as int<%d>", value, suffix, width); return msg; } > - Which check do we run? > > I initially tried running distcheck, but automake would delete the resulting > test run AFAICT. I'm not entirely sure how to work around that yet (and the > night is catching up with me at this point). As a result, I switched to just > check. Would distcheck even benefit us on CI? My current thinking is "maybe > not", and it does result in compiling poke twice, FWIW. I changed the distcheck step to a normal make check step. > ... and, of course, the rest of the patch is up for discussion ;) It looks good. Pushed. The only thing that concerns me a little is the ./bootstrap step. That seems to pull in all of gnulib on every build. We might want to see if that can be cached somehow. In general ./bootstrap seems to take longer than a make && make check. Cheers, Mark