Re: [builder] gdb_check_step: remove gdb.gdb/selftest.exp

[Mark Wielaard <mark@klomp.org>]

[-- Attachment #1: Type: text/plain, Size: 888 bytes --]

On Fri, Jun 10, 2022 at 01:09:19AM +0200, Mark Wielaard wrote:
> On Thu, Jun 09, 2022 at 10:37:58AM +0100, Luis Machado wrote:
> > I always use gdb.base/break.exp as a good smoke test. If that one fails, then things
> > are really broken.
> > 
> > I think gdb.base/break*.exp should make a good smoke test list. We just need to exclude
> > gdb.base/break-interp.exp, which is problematic on some targets.
> 
> It never is just easy is it? :) You are right, I saw break-interp.exp
> fail...  I tried to come up with a regexp but gave up given that it
> has to go throug python first and then we don't know whether the
> worker uses bash as /bin/sh so I just added them all (exclusing
> break-interp.exp) as a list.

Sigh, sorry, looks like gdb.base/break-unload-file.exp also sometimes fails.
I have removed from the list. Hopefully the remaining list does actually pass.

Cheers,

Mark



[-- Attachment #2: 0001-gdb_test_exp-Remove-gdb.base-break-unload-file.exp.patch --]
[-- Type: text/x-diff, Size: 764 bytes --]

From 49a95a50543a772d4413078c34de520e2e2a9610 Mon Sep 17 00:00:00 2001
From: Mark Wielaard <mark@klomp.org>
Date: Fri, 10 Jun 2022 01:20:19 +0200
Subject: [PATCH] gdb_test_exp: Remove gdb.base/break-unload-file.exp

---
 builder/master.cfg | 1 -
 1 file changed, 1 deletion(-)

diff --git a/builder/master.cfg b/builder/master.cfg
index f6895b5..e413d3f 100644
--- a/builder/master.cfg
+++ b/builder/master.cfg
@@ -1461,7 +1461,6 @@ gdb_test_exp = ("TESTS= "
                 "gdb.base/breakpoint-in-ro-region.exp "
                 "gdb.base/breakpoint-shadow.exp "
                 "gdb.base/break-probes.exp "
-                "gdb.base/break-unload-file.exp "
                 "gdb.gdb/unittest.exp "
                 "gdb.server/unittest.exp ")
 
-- 
2.30.2