From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (gnu.wildebeest.org [45.83.234.184]) by sourceware.org (Postfix) with ESMTPS id 42FAD382B580; Thu, 9 Jun 2022 23:21:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 42FAD382B580 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org Received: from reform (deer0x09.wildebeest.org [172.31.17.139]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 2E793302BBEB; Fri, 10 Jun 2022 01:21:16 +0200 (CEST) Received: by reform (Postfix, from userid 1000) id EF94C2E83DB8; Fri, 10 Jun 2022 01:21:15 +0200 (CEST) Date: Fri, 10 Jun 2022 01:21:15 +0200 From: Mark Wielaard To: Luis Machado Cc: gdb@sourceware.org, buildbot@sourceware.org Subject: Re: [builder] gdb_check_step: remove gdb.gdb/selftest.exp Message-ID: References: <20220608185138.675964-1-mark@klomp.org> <2281be8e-8920-7ba5-9e96-ffd713462b9c@arm.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="0AwdltTKThNfRvnE" Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-11.5 required=5.0 tests=BAYES_00, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: buildbot@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "The https://builder.sourceware.org/ buildbot" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Jun 2022 23:21:18 -0000 --0AwdltTKThNfRvnE Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Jun 10, 2022 at 01:09:19AM +0200, Mark Wielaard wrote: > On Thu, Jun 09, 2022 at 10:37:58AM +0100, Luis Machado wrote: > > I always use gdb.base/break.exp as a good smoke test. If that one fails, then things > > are really broken. > > > > I think gdb.base/break*.exp should make a good smoke test list. We just need to exclude > > gdb.base/break-interp.exp, which is problematic on some targets. > > It never is just easy is it? :) You are right, I saw break-interp.exp > fail... I tried to come up with a regexp but gave up given that it > has to go throug python first and then we don't know whether the > worker uses bash as /bin/sh so I just added them all (exclusing > break-interp.exp) as a list. Sigh, sorry, looks like gdb.base/break-unload-file.exp also sometimes fails. I have removed from the list. Hopefully the remaining list does actually pass. Cheers, Mark --0AwdltTKThNfRvnE Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0001-gdb_test_exp-Remove-gdb.base-break-unload-file.exp.patch" >From 49a95a50543a772d4413078c34de520e2e2a9610 Mon Sep 17 00:00:00 2001 From: Mark Wielaard Date: Fri, 10 Jun 2022 01:20:19 +0200 Subject: [PATCH] gdb_test_exp: Remove gdb.base/break-unload-file.exp --- builder/master.cfg | 1 - 1 file changed, 1 deletion(-) diff --git a/builder/master.cfg b/builder/master.cfg index f6895b5..e413d3f 100644 --- a/builder/master.cfg +++ b/builder/master.cfg @@ -1461,7 +1461,6 @@ gdb_test_exp = ("TESTS= " "gdb.base/breakpoint-in-ro-region.exp " "gdb.base/breakpoint-shadow.exp " "gdb.base/break-probes.exp " - "gdb.base/break-unload-file.exp " "gdb.gdb/unittest.exp " "gdb.server/unittest.exp ") -- 2.30.2 --0AwdltTKThNfRvnE--