public inbox for buildbot@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] Fix builder step name.
@ 2022-06-16  5:08 Martin Liška
  2022-06-16 21:35 ` Mark Wielaard
  0 siblings, 1 reply; 2+ messages in thread
From: Martin Liška @ 2022-06-16  5:08 UTC (permalink / raw)
  To: buildbot; +Cc: Mark Wielaard

Change builder step like:
make -k checkCC_FOR_TARGET=clang CXX_FOR_TARGET=cl

to
make -k check CC_FOR_TARGET=clang CXX_FOR_TARGET=cl
---
 builder/master.cfg | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/builder/master.cfg b/builder/master.cfg
index 8455dfe..e49b2fa 100644
--- a/builder/master.cfg
+++ b/builder/master.cfg
@@ -1638,7 +1638,7 @@ def binutils_gdb_factory_factory(runtestflags=None):
                 make_check_command.append('RUNTESTFLAGS='+runtestflags)
         binutils_gdb_factory.addStep(steps.Test(
                 command=make_check_command,
-                name=('make -k check' + (runtestflags if runtestflags else ''))[:50], # length limit
+                name=('make -k check' + (' ' + runtestflags if runtestflags else ''))[:50], # length limit
                 timeout=14400, # 4 hours should be enough to get some output
                 haltOnFailure=False, flunkOnFailure=False))  # test failure = ok
         binutils_gdb_factory.addStep(steps.ShellCommand(
-- 
2.36.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] Fix builder step name.
  2022-06-16  5:08 [PATCH] Fix builder step name Martin Liška
@ 2022-06-16 21:35 ` Mark Wielaard
  0 siblings, 0 replies; 2+ messages in thread
From: Mark Wielaard @ 2022-06-16 21:35 UTC (permalink / raw)
  To: Martin Liška; +Cc: buildbot

Hi Martin,

On Thu, Jun 16, 2022 at 07:08:49AM +0200, Martin Liška wrote:
> Change builder step like:
> make -k checkCC_FOR_TARGET=clang CXX_FOR_TARGET=cl
> 
> to
> make -k check CC_FOR_TARGET=clang CXX_FOR_TARGET=cl

Looks good to me. Please push.

Thanks,

Mark

> ---
>  builder/master.cfg | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/builder/master.cfg b/builder/master.cfg
> index 8455dfe..e49b2fa 100644
> --- a/builder/master.cfg
> +++ b/builder/master.cfg
> @@ -1638,7 +1638,7 @@ def binutils_gdb_factory_factory(runtestflags=None):
>                  make_check_command.append('RUNTESTFLAGS='+runtestflags)
>          binutils_gdb_factory.addStep(steps.Test(
>                  command=make_check_command,
> -                name=('make -k check' + (runtestflags if runtestflags else ''))[:50], # length limit
> +                name=('make -k check' + (' ' + runtestflags if runtestflags else ''))[:50], # length limit
>                  timeout=14400, # 4 hours should be enough to get some output
>                  haltOnFailure=False, flunkOnFailure=False))  # test failure = ok
>          binutils_gdb_factory.addStep(steps.ShellCommand(
> -- 
> 2.36.1
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-06-16 21:35 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-16  5:08 [PATCH] Fix builder step name Martin Liška
2022-06-16 21:35 ` Mark Wielaard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).