From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (gnu.wildebeest.org [45.83.234.184]) by sourceware.org (Postfix) with ESMTPS id 9FCE2384F025; Wed, 29 Jun 2022 22:42:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9FCE2384F025 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org Received: from reform (deer0x0e.wildebeest.org [172.31.17.144]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 6DE7130005B6; Thu, 30 Jun 2022 00:42:38 +0200 (CEST) Received: by reform (Postfix, from userid 1000) id 306812E81924; Thu, 30 Jun 2022 00:42:38 +0200 (CEST) Date: Thu, 30 Jun 2022 00:42:38 +0200 From: Mark Wielaard To: Carl Love Cc: Luis Machado , Will Schmidt , gdb@sourceware.org, buildbot@sourceware.org Subject: Re: [builder] gdb_check_step: remove gdb.gdb/selftest.exp Message-ID: References: <20220608185138.675964-1-mark@klomp.org> <2281be8e-8920-7ba5-9e96-ffd713462b9c@arm.com> <8bfa7ec63758afc45bde1f10b0e4ab91e21e9d06.camel@klomp.org> <85fa6e2d-caf5-8afe-a7ec-40cc62ff347a@arm.com> <4649417b632758c6822214b19f04ce70146c43cb.camel@us.ibm.com> <3df33b29575bcd78d12c5178dadd274b225b0e7d.camel@us.ibm.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="hf7/fBnvr8FIk4s9" Content-Disposition: inline In-Reply-To: <3df33b29575bcd78d12c5178dadd274b225b0e7d.camel@us.ibm.com> X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: buildbot@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "The https://builder.sourceware.org/ buildbot" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Jun 2022 22:42:41 -0000 --hf7/fBnvr8FIk4s9 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Carl, On Wed, Jun 29, 2022 at 08:58:43AM -0700, Carl Love wrote: > The test was failing the same way when running locally. It was a test > issue related to checking for hardware watchpoint support on PowerPC. I > posted a patch to fix it. Andrew Burgess merged a similar patch that > he did to fix the test with my patch and committed the fix. The test > is now running correctly locally. Note, I have not tested it in the > remote configuration as you mentioned. Here is the commit for the > fix: > > commit 13f72372413400410aaa94b7f0e2ff7de663fdcb > Author: Carl Love > Date: Wed Jun 22 16:14:20 2022 +0100 > > gdb/testsuite: fix gdb.base/break-idempotent.exp on ppc > > When running the gdb.base/break-idempotent.exp test on ppc, I was > seeing some test failures (or rather errors), that looked like > this: > > (gdb) watch local > Hardware watchpoint 2: local > > has_hw_wp_support: Hardware watchpoint detected > ERROR: no fileid for gcc2-power8 > ERROR: Couldn't send delete breakpoints to GDB. > ERROR OCCURED: can't read "gdb_spawn_id": no such variable > while executing > ... > > Please let me know if you see any additional issues with the test. Lets add it back to the buildbot tests and see if anything breaks. Cheers, Mark --hf7/fBnvr8FIk4s9 Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0001-gdb_test_exp-Add-gdb.base-break-idempotent.exp-back.patch" >From a1f7675ab2fa8a4c987d0e7f1fb53de564cf9ed9 Mon Sep 17 00:00:00 2001 From: Mark Wielaard Date: Thu, 30 Jun 2022 00:40:08 +0200 Subject: [PATCH] gdb_test_exp: Add gdb.base/break-idempotent.exp back This should now work on all arches --- builder/master.cfg | 1 + 1 file changed, 1 insertion(+) diff --git a/builder/master.cfg b/builder/master.cfg index 219f88d..729ec37 100644 --- a/builder/master.cfg +++ b/builder/master.cfg @@ -1820,6 +1820,7 @@ gdb_test_exp = ("TESTS= " "gdb.base/break-entry.exp " "gdb.base/break.exp " "gdb.base/break-fun-addr.exp " + "gdb.base/break-idempotent.exp " "gdb.base/break-include.exp " "gdb.base/break-inline.exp " "gdb.base/break-main-file-remove-fail.exp " -- 2.30.2 --hf7/fBnvr8FIk4s9--