Re: Arm GCC buildbot workers

[Mark Wielaard <mark@klomp.org>]

[-- Attachment #1: Type: text/plain, Size: 867 bytes --]

Hi Christophe,

On Wed, Aug 17, 2022 at 03:45:07PM +0200, Christophe Lyon wrote:
> > Currently the configure line is shared by all gcc-full builders. But
> > that can be changed. As in the attached patch (apologies for my python
> > skills). I'll push it once I have internet access again.
> 
> In case you have missed my follow-up message, the buildbot patch is not
> needed anymore: I pushed a fix in GCC instead :-)

Yes, sorry. I am on vacation in the mountains with spotty interweb
access, so sending/receiving emails in batches. Our emails crossed.

I like your gcc patch very much. It is much better if configure does
the right thing by default.

I removed the extra configure argument for the
gcc_full_ubuntu_armhf_builder. But kept the generator function just in
case we do want to have different configure arguments per builder in
the future.

Cheers,

Mark

[-- Attachment #2: 0001-Remove-with-float-hard-for-gcc_full_ubuntu_armhf_bui.patch --]
[-- Type: text/x-diff, Size: 964 bytes --]

From f4711d650a5f706d599a3122e6e54ca4f2cc2286 Mon Sep 17 00:00:00 2001
From: Mark Wielaard <mark@klomp.org>
Date: Wed, 17 Aug 2022 22:39:28 +0200
Subject: [PATCH] Remove --with-float=hard for gcc_full_ubuntu_armhf_builder

gcc configure should now do the right thing automatically.
---
 builder/master.cfg | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/builder/master.cfg b/builder/master.cfg
index dc51fd0..318adad 100644
--- a/builder/master.cfg
+++ b/builder/master.cfg
@@ -3033,8 +3033,7 @@ gcc_full_ubuntu_armhf_builder = util.BuilderConfig(
         collapseRequests=True,
         workernames=["ubuntu22_04-armhf"],
         tags=["gcc-full", "ubuntu", "armhf"],
-        factory=gcc_full_build_factory_gen(
-                extra_configure_arg="--with-float=hard"))
+        factory=gcc_full_build_factory_gen())
 c['builders'].append(gcc_full_ubuntu_armhf_builder)
 
 gcc_full_ubuntu_arm64_builder = util.BuilderConfig(
-- 
2.30.2