From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (gnu.wildebeest.org [45.83.234.184]) by sourceware.org (Postfix) with ESMTPS id 9DFE23858D37 for ; Wed, 17 Aug 2022 20:42:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9DFE23858D37 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org Received: from reform (unknown [178.228.156.55]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id CA79F300070C; Wed, 17 Aug 2022 22:42:25 +0200 (CEST) Received: by reform (Postfix, from userid 1000) id C22512E8157E; Wed, 17 Aug 2022 22:42:23 +0200 (CEST) Date: Wed, 17 Aug 2022 22:42:23 +0200 From: Mark Wielaard To: Christophe Lyon Cc: buildbot@sourceware.org Subject: Re: Arm GCC buildbot workers Message-ID: References: <84fe482f-0b5e-face-9a7a-bb04ac162686@arm.com> <20220811203956.GE5520@gnu.wildebeest.org> <20220812164415.GI5520@gnu.wildebeest.org> <45bd3411-6b54-c49e-3b6d-5cbf85a5dd10@arm.com> <01b98c46-e1cd-e463-ee0c-88b26db76242@arm.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="iS+3AJWGja0WsDzz" Content-Disposition: inline In-Reply-To: <01b98c46-e1cd-e463-ee0c-88b26db76242@arm.com> X-Spam-Status: No, score=-10.5 required=5.0 tests=BAYES_00, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: buildbot@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "The https://builder.sourceware.org/ buildbot" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Aug 2022 20:42:28 -0000 --iS+3AJWGja0WsDzz Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Christophe, On Wed, Aug 17, 2022 at 03:45:07PM +0200, Christophe Lyon wrote: > > Currently the configure line is shared by all gcc-full builders. But > > that can be changed. As in the attached patch (apologies for my python > > skills). I'll push it once I have internet access again. > > In case you have missed my follow-up message, the buildbot patch is not > needed anymore: I pushed a fix in GCC instead :-) Yes, sorry. I am on vacation in the mountains with spotty interweb access, so sending/receiving emails in batches. Our emails crossed. I like your gcc patch very much. It is much better if configure does the right thing by default. I removed the extra configure argument for the gcc_full_ubuntu_armhf_builder. But kept the generator function just in case we do want to have different configure arguments per builder in the future. Cheers, Mark --iS+3AJWGja0WsDzz Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0001-Remove-with-float-hard-for-gcc_full_ubuntu_armhf_bui.patch" >From f4711d650a5f706d599a3122e6e54ca4f2cc2286 Mon Sep 17 00:00:00 2001 From: Mark Wielaard Date: Wed, 17 Aug 2022 22:39:28 +0200 Subject: [PATCH] Remove --with-float=hard for gcc_full_ubuntu_armhf_builder gcc configure should now do the right thing automatically. --- builder/master.cfg | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/builder/master.cfg b/builder/master.cfg index dc51fd0..318adad 100644 --- a/builder/master.cfg +++ b/builder/master.cfg @@ -3033,8 +3033,7 @@ gcc_full_ubuntu_armhf_builder = util.BuilderConfig( collapseRequests=True, workernames=["ubuntu22_04-armhf"], tags=["gcc-full", "ubuntu", "armhf"], - factory=gcc_full_build_factory_gen( - extra_configure_arg="--with-float=hard")) + factory=gcc_full_build_factory_gen()) c['builders'].append(gcc_full_ubuntu_armhf_builder) gcc_full_ubuntu_arm64_builder = util.BuilderConfig( -- 2.30.2 --iS+3AJWGja0WsDzz--