[PATCH] rhel10-x86_64: add systemtap builder

[PATCH] rhel10-x86_64: add systemtap builder

[Serhei Makarov]

From b6804dcb3fedac5fd06946c9017a7fba5f2ccbe6 Mon Sep 17 00:00:00 2001
From: Serhei Makarov <serhei@serhei.io>
Date: Thu, 20 Feb 2025 12:41:02 -0500
Subject: [PATCH] rhel10-x86_64: add systemtap builder

---
 builder/master.cfg | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/builder/master.cfg b/builder/master.cfg
index d02f3d7..0ccd23d 100644
--- a/builder/master.cfg
+++ b/builder/master.cfg
@@ -243,6 +243,14 @@ fedora39_x86_64_systemtap_privileged_worker = worker.Worker(
         notify_on_missing=['smakarov@redhat.com'])
 c['workers'].append(fedora39_x86_64_systemtap_privileged_worker)
 
+rhel10_x86_64_systemtap_privileged_worker = worker.Worker(
+        "stap-rhel10-x86_64",
+        getpw("stap-rhel10-x86_64"),
+        max_builds=1,
+        properties={'ncpus': 2, 'maxcpus': 2},
+        notify_on_missing=['smakarov@redhat.com'])
+c['workers'].append(rhel10_x86_64_systemtap_privileged_worker)
+
 rhel9_x86_64_systemtap_privileged_worker = worker.Worker(
         "stap-rhel9-x86_64",
         getpw("stap-rhel9-x86_64"),
@@ -1195,6 +1203,7 @@ systemtap_privileged_buildernames = [
         "stap-fedora41-x86_64",
         "stap-fedora40-x86_64",
         "stap-fedora39-x86_64",
+        "stap-rhel10-x86_64",
         "stap-rhel9-x86_64",
         "stap-rhel8-x86_64",
         "stap-c10s-x86_64",
@@ -5363,6 +5372,14 @@ systemtap_fedora39_x86_64_privileged_builder = util.BuilderConfig(
         factory=systemtap_privileged_factory)
 c['builders'].append(systemtap_fedora39_x86_64_privileged_builder)
 
+systemtap_rhel10_x86_64_privileged_builder = util.BuilderConfig(
+        name="stap-rhel10-x86_64",
+        collapseRequests=True,
+        workernames=["stap-rhel10-x86_64"],
+        tags=["systemtap", "rhel", "x86_64"],
+        factory=systemtap_privileged_factory)
+c['builders'].append(systemtap_rhel10_x86_64_privileged_builder)
+
 systemtap_rhel9_x86_64_privileged_builder = util.BuilderConfig(
         name="stap-rhel9-x86_64",
         collapseRequests=True,
-- 
2.47.0

Re: [PATCH] rhel10-x86_64: add systemtap builder

[Mark Wielaard]

Hi Serhei,

On Thu, Feb 20, 2025 at 12:44:01PM -0500, Serhei Makarov wrote:
> From b6804dcb3fedac5fd06946c9017a7fba5f2ccbe6 Mon Sep 17 00:00:00 2001
> From: Serhei Makarov <serhei@serhei.io>
> Date: Thu, 20 Feb 2025 12:41:02 -0500
> Subject: [PATCH] rhel10-x86_64: add systemtap builder

And worker.

> ---
>  builder/master.cfg | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
> 
> diff --git a/builder/master.cfg b/builder/master.cfg
> index d02f3d7..0ccd23d 100644
> --- a/builder/master.cfg
> +++ b/builder/master.cfg
> @@ -243,6 +243,14 @@ fedora39_x86_64_systemtap_privileged_worker = worker.Worker(
>          notify_on_missing=['smakarov@redhat.com'])
>  c['workers'].append(fedora39_x86_64_systemtap_privileged_worker)
>  
> +rhel10_x86_64_systemtap_privileged_worker = worker.Worker(
> +        "stap-rhel10-x86_64",
> +        getpw("stap-rhel10-x86_64"),
> +        max_builds=1,
> +        properties={'ncpus': 2, 'maxcpus': 2},
> +        notify_on_missing=['smakarov@redhat.com'])
> +c['workers'].append(rhel10_x86_64_systemtap_privileged_worker)

I'll sent you a password for this new worker off list. Is this setup
reachable for others? Or can others setup a similar worker for local
testing?

There should also be a dummy entry in buildbot.config.sample

diff --git a/buildbot.config.sample b/buildbot.config.sample
index f18ebb6d5318..e25b9bb0068e 100644
--- a/buildbot.config.sample
+++ b/buildbot.config.sample
@@ -40,6 +40,7 @@ stap-fedrawhide-x86_64=frob
 stap-fedora41-x86_64=frob
 stap-fedora40-x86_64=frob
 stap-fedora39-x86_64=frob
+stap-rhel10-x86_64=frob
 stap-rhel9-x86_64=frob
 stap-rhel8-x86_64=frob
 stap-c10s-x86_64=frob

>  rhel9_x86_64_systemtap_privileged_worker = worker.Worker(
>          "stap-rhel9-x86_64",
>          getpw("stap-rhel9-x86_64"),
> @@ -1195,6 +1203,7 @@ systemtap_privileged_buildernames = [
>          "stap-fedora41-x86_64",
>          "stap-fedora40-x86_64",
>          "stap-fedora39-x86_64",
> +        "stap-rhel10-x86_64",
>          "stap-rhel9-x86_64",
>          "stap-rhel8-x86_64",
>          "stap-c10s-x86_64",
> @@ -5363,6 +5372,14 @@ systemtap_fedora39_x86_64_privileged_builder = util.BuilderConfig(
>          factory=systemtap_privileged_factory)
>  c['builders'].append(systemtap_fedora39_x86_64_privileged_builder)
>  
> +systemtap_rhel10_x86_64_privileged_builder = util.BuilderConfig(
> +        name="stap-rhel10-x86_64",
> +        collapseRequests=True,
> +        workernames=["stap-rhel10-x86_64"],
> +        tags=["systemtap", "rhel", "x86_64"],
> +        factory=systemtap_privileged_factory)
> +c['builders'].append(systemtap_rhel10_x86_64_privileged_builder)
> +
>  systemtap_rhel9_x86_64_privileged_builder = util.BuilderConfig(
>          name="stap-rhel9-x86_64",
>          collapseRequests=True,

Thanks,

Mark

Re: [PATCH] rhel10-x86_64: add systemtap builder

[Serhei Makarov]

On Thu, Feb 20, 2025, at 3:30 PM, Mark Wielaard wrote:
> It would also be good to explain on list what this "rhel10" exactly
> is. I don't believe others can easily replicate it (or is it really
> c10s?)
Yeah, it's worth explaining a lot more. + raising an question or two.

On builder.sourceware.org there are two rows 'stap' and 'systemtap', referring to different buildbots.

'systemtap' is systemtap builds on a public buildbot machine, and those do not run the testsuite (which require kernel access and include tests beyond the default safety settings that would stress the stability of a shared system). So that gives very limited data.

'stap' is a set of *separate* builders, on a machine internal to Red Hat, which run the full systemtap testsuite in a virtualized environment. This includes the RHEL vms (currently RHEL8,9,10; actual RHEL as built by Red Hat), as well as CentOS Stream. We want to keep running our tests on RHEL, so if those vms aren't appropriate to list on builder.sourceware.org I would probably (a) keep running the RHEL VMs but feed results to a non-public bunsen instance and (b) replace the VMs feeding results to builder.sourceware.org with almalinux as suggested. For the other distros covered by the 'stap' VMs (Fedora and CentOS) I'm planning to open up the scripting that *creates* those buildbots, which would allow a similar environment to be quickly re-created. But the actual VMs aren't in a place that we could open up for direct access by the public.

Would it be worth renaming either 'stap' or 'systemtap' in a way that makes the distinction more obvious?

> I would recommend using alma linux for public workers so others can
> more easily replicate such a setup. I never could get a straight
> answer from Red Hat how to setup a RHEL buildbot CI for (shared)
> public use.
AIUI I don't think publishing test results from a non-public-accessible RHEL system is a problem for Red Hat, so long as the relevant RHEL version has been announced. It's purely a question of whether hosting those results is within the mission scope of sourceware or not, or if you only want results from public buildbots.

There's also a question of using bunsen results to collect test data on other architectures from only intermittently-available hardware, rather than a permanent buildbot. I tried to do this with the older bunsen prototype, before we moved the system to sourceware. Here I'm not sure whether it's appropriate to do that with sourceware resources or with a separate bunsen instance.

-- 
All the best,
    Serhei
    http://serhei.io

Re: [PATCH] rhel10-x86_64: add systemtap builder

[Frank Ch. Eigler]

Hi -

> > It would also be good to explain on list what this "rhel10" exactly
> > is. I don't believe others can easily replicate it (or is it really
> > c10s?)

RHEL10-beta has been made available to RHEL customers months ago, AIUI
including freebie RHEL developer subscription users.  It's not mystery
meat.

> Would it be worth renaming either 'stap' or 'systemtap' in a way
> that makes the distinction more obvious?

(I don't think it really matters.  tag=systemtap finds them both, no
big deal.)


- FChE