From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from elastic.org (elastic.org [96.126.110.187]) by sourceware.org (Postfix) with ESMTPS id A82133858D34 for ; Wed, 6 Mar 2024 17:14:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A82133858D34 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=elastic.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=elastic.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A82133858D34 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=96.126.110.187 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709745274; cv=none; b=qnOXoFw9zObjFjq1g2G2cHeTIfFFS0vADvzHD9HUE1dSjamdZHfvzzVuYOshBRA6CdB8QeXHFgdgnChAKckTov+8Vv+eWsTVY6hoxI+WpctnsgxlprVCjZ2+q7u/AmnVFOXDNPNfoZ+p5H79R1ZFqszApE5Fz+mzYdKig6mx+Yw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709745274; c=relaxed/simple; bh=zl2byZA88mAYi9Rkn4/X565HzIkUemMw2ZlUZhnWQb4=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=rNNest1/bnwokexcYX5mwMRW9OwUphVqDPDECTjPxnzJ4EtjNibrkbJsk48GokSZhw2EZ1h0pXlmzQf77KMxr+7i5tDwnbR6sku7+VVOHkOs+b6yBwScB8Sl6pofO8l8pmvO7zggu1JNHzuPRFOFyuUi0Ghd2VRtoGR3bNGmEUo= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=elastic.org ; s=default2; h=Content-Type:MIME-Version:Message-ID:Subject:To:From:Date: Sender:Reply-To:Cc:Content-Transfer-Encoding:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=BxmgcAtLR3LRhrAr/X1OUBNxZaGTHDiX97fbfkvbp8Y=; b=frT8SjW2tDRB/Hsqk154/Og2kJ 5M8CUbZVbEpWydZIEC5SASGmmsExtGIEWjriVjTqhb0loCMzJydrpNOaBHgTKfLO4kg2Myx7eYadi zj6wmlby+0kSM4tMcBWA2I3yL+K81XfZ6980t+JmkIZLyqT9bclpxutnJsCg4L11yd+ME+hiFh4Yy g5MmFCgr+h87lQxCz2+j9LjWu7LFY0DrI4ub1BxXW/txiOgNHRVwAfhy4DVgKyy9j0y8VpBr2GQ9U xLPROUWgF3Tmq6XTU2Meauspa1TMndXmJmv0PsYyCB1NdoUKb36ZmtS7FiRMMnfopLtqUQhQ41R8B x6UyHDyg==; Received: from vpn-home.elastic.org ([10.0.0.2] helo=elastic.org) by elastic.org with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.97.1) (envelope-from ) id 1rhuqe-000000000x6-1uEP for buildbot@sourceware.org; Wed, 06 Mar 2024 17:14:32 +0000 Received: from very.elastic.org ([192.168.1.1]) by elastic.org with esmtp (Exim 4.97.1) (envelope-from ) id 1rhuqd-000000007Yx-39bS for buildbot@sourceware.org; Wed, 06 Mar 2024 12:14:32 -0500 Received: from fche by very.elastic.org with local (Exim 4.97.1) (envelope-from ) id 1rhuqd-00000006eop-2ugH for buildbot@sourceware.org; Wed, 06 Mar 2024 12:14:31 -0500 Date: Wed, 6 Mar 2024 12:14:31 -0500 From: "Frank Ch. Eigler" To: buildbot@sourceware.org Subject: patch: use "make -k check" broadly Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Sender-Verification: "" X-Spam-Status: No, score=-108.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE,USER_IN_WELCOMELIST,USER_IN_WHITELIST autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi - The following diff gets the annobin and a few other package make_check* steps to use "make -k check" rather than "make check", so that early partial failures do not doom the entire run. Many other package builders already use the equivalent. diff --git a/builder/master.cfg b/builder/master.cfg index e4cd0802a051..d0b046f7af19 100644 --- a/builder/master.cfg +++ b/builder/master.cfg @@ -1194,26 +1194,26 @@ make_pdf_step = steps.Compile( command=["make", "pdf"], name="make pdf") make_check_step = steps.Test( - command=addOutputSync.withArgs(["make", "check", + command=addOutputSync.withArgs(["make", "-k", "check", util.Interpolate('-j%(prop:ncpus)s')]), name="make check", haltOnFailure=False, flunkOnFailure=True) # make check explicitly not using -j make_single_check_step = steps.Test( - command=["make", "check"], + command=["make", "-k", "check"], name="make check") make_single_test_suite_step = steps.Test( - command=["make", "check"], + command=["make", "-k" "check"], name="make check", logfiles={"test-suite.log": "tests/test-suite.log"}) # Same as make_check_step but with tests/test-suite.log recorded make_check_test_suite_step = steps.Test( - command=addOutputSync.withArgs(["make", "check", + command=addOutputSync.withArgs(["make", "-k", "check", util.Interpolate('-j%(prop:ncpus)s')]), name="make check", haltOnFailure=False, flunkOnFailure=True, logfiles={"test-suite.log": "tests/test-suite.log"}) # Same but with tests/testsuite.log (note, no dash) make_check_testsuite_step = steps.Test( - command=addOutputSync.withArgs(["make", "check", + command=addOutputSync.withArgs(["make", "-k", "check", util.Interpolate('-j%(prop:ncpus)s')]), name="make check", haltOnFailure=False, flunkOnFailure=True, logfiles={"testsuite.log": "tests/testsuite.log"}) - FChE