public inbox for buildbot@sourceware.org
 help / color / mirror / Atom feed
From: "Frank Ch. Eigler" <fche@elastic.org>
To: buildbot@sourceware.org
Subject: proposed patch: gcc-fullest builder to build+check multilib -m32/-m64
Date: Fri, 27 Sep 2024 13:43:32 -0400	[thread overview]
Message-ID: <ZvbuxIiwreDkNI6a@elastic.org> (raw)

Hi -

Proposing here instead of pushing because ... i'm not sure quoting is
quite right, so want to give a heads up for some trial & error.

diff --git a/builder/master.cfg b/builder/master.cfg
index cfa7f13ad683..43b893e51b49 100644
--- a/builder/master.cfg
+++ b/builder/master.cfg
@@ -4074,7 +4074,8 @@ c['builders'].append(gcc_fedora_ppc64le_builder)
 #c['builders'].append(gcc_debian_testing_x86_64_builder)
 
 def gcc_full_build_factory_gen(extra_configure_args=None,
-                               extra_setup_step=None):
+                               extra_setup_step=None,
+                               extra_check_args=None):
         gcc_full_build_factory = util.BuildFactory()
         gcc_full_build_factory.addStep(gcc_build_git_step)
         gcc_full_build_factory.addStep(gcc_rm_build_step)
@@ -4100,10 +4101,12 @@ def gcc_full_build_factory_gen(extra_configure_args=None,
                 haltOnFailure=True))
         # We want parallelism to get through this as quickly as possible.
         # Even if that means bunsen gets some parallel/duplicate log files
+        make_check_command = "make check -k -j%(prop:maxcpus)s "
+        if extra_check_args:
+                make_check_command += extra_check_args # NB: just string concat inside the sh -c
         gcc_full_build_factory.addStep(steps.Test(
                 workdir='gcc-build',
-                command=util.Interpolate(
-                        "make check -k -j%(prop:maxcpus)s || true"),
+                command=util.Interpolate(make_check_command + " || true"),
                 name='make check',
                 timeout=7200, # 2 hours
                 haltOnFailure=False, flunkOnFailure=False))
@@ -4128,11 +4131,13 @@ gcc_fullest_debian_amd64_builder = util.BuilderConfig(
                     readContainerFile('debian-stable')},
         workernames=big_vm_workers,
         tags=["gcc-full", "debian", "x86_64"],
-        factory=gcc_full_build_factory_gen([
+        factory=gcc_full_build_factory_gen(extra_configure_args=[
                 "--enable-checking=yes,extra,rtl",
                 "--enable-languages=all",
                 "--enable-host-shared",
-        ]))
+                "--enable-multilib-list=m32,m64" # multilib!
+        ],extra_check_args=r"RUNTESTFLAGS=--target_board=unix\\{,-m32\\}") # NB: quoting
+        )
 c['builders'].append(gcc_fullest_debian_amd64_builder)
 
 gcc_full_debian_amd64_builder = util.BuilderConfig(

             reply	other threads:[~2024-09-27 17:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-27 17:43 Frank Ch. Eigler [this message]
2024-09-29 20:04 ` Mark Wielaard
2024-09-29 20:09   ` Frank Ch. Eigler
2024-09-29 20:23     ` Mark Wielaard
2024-09-29 20:34       ` Frank Ch. Eigler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZvbuxIiwreDkNI6a@elastic.org \
    --to=fche@elastic.org \
    --cc=buildbot@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).