RE: [builder] gdb_check_step: remove gdb.gdb/selftest.exp

[Carl Love <cel@us.ibm.com>]

Mark:

On Fri, 2022-06-10 at 21:11 +0200, Mark Wielaard wrote:
> Hi Carl,
> 
> On Fri, Jun 10, 2022 at 08:54:00AM -0700, Carl Love wrote:
> > On Fri, 2022-06-10 at 11:58 +0100, Luis Machado wrote:
> > > On 6/10/22 11:50, Mark Wielaard wrote:
> > > > On Fri, 2022-06-10 at 01:21 +0200, Mark Wielaard wrote:
> > > > > On Fri, Jun 10, 2022 at 01:09:19AM +0200, Mark Wielaard
> > > > > wrote:
> > > > > > On Thu, Jun 09, 2022 at 10:37:58AM +0100, Luis Machado
> > > > > > wrote:
> > > > > > > I always use gdb.base/break.exp as a good smoke test. If
> > > > > > > that
> > > > > > > one
> > > > > > > fails, then things
> > > > > > > are really broken.
> > > > > > > 
> > > > > > > I think gdb.base/break*.exp should make a good smoke test
> > > > > > > list.
> > > > > > > We just need to exclude
> > > > > > > gdb.base/break-interp.exp, which is problematic on some
> > > > > > > targets.
> > 
> > Trying to to understand how you are running the test.  I think you
> > are
> > running these as remote tests, i.e. machine A requests that a
> > remote
> > machine B run the test via gdbserver, correct?
> 
> Yes, but machine A and B are the same one in this case.  The tests
> are
> run three times. Once with just gdb, and then with a target-board set
> to either native-gdbserver or native-extended-gdbserver.
> 
> The buildbot log stdio should show you the exact settings.
> 
> https://builder.sourceware.org/buildbot/#/builders/76/builds/446/steps/12/logs/stdio 
> 
> make -j4 check-gdb 'TESTS= gdb.base/break-always.exp gdb.base/break-
> caller-line.exp gdb.base/break-entry.exp gdb.base/break.exp
> gdb.base/break-fun-addr.exp gdb.base/break-idempotent.exp
> gdb.base/break-include.exp gdb.base/break-inline.exp gdb.base/break-
> main-file-remove-fail.exp gdb.base/break-on-linker-gcd-function.exp
> gdb.base/breakpoint-in-ro-region.exp gdb.base/breakpoint-shadow.exp
> gdb.base/break-probes.exp gdb.gdb/unittest.exp
> gdb.server/unittest.exp ' 'RUNTESTFLAGS="--target_board=native-
> gdbserver"'
> 
> So it is the RUNTESTFLAGS="--target_board=native-gdbserver" that
> tells
> the test to run against the native-gdbserver.

OK, thanks that will be helpful for testing. 

So, I have been trying to isolate where the messages 
  
   ERROR: no fileid for ltcd97-lp2
   ERROR: Couldn't send delete breakpoints to GDB.
   ERROR: can't read "gdb_spawn_id": no such variable

Looks like a couple of the error messages are coming from proc
default_gdb_exit.  The routine is called as part of the check in the
original test program.  The break-idempotent.exp calls
skip_hw_watchpoint_tests  which calls has_hw_wp_support  which calls
gdb_exit which calls proc default_gdb_exit.  In default_gdb_exit we
have:

   if ![is_remote host] {

        remote_close host     <-   generates ERROR: no fileid for ltcd97-lp2
    }
    unset gdb_spawn_id        <-   generates ERROR: can't read "gdb_spawn_id": no such variable
    unset ::gdb_tty_name

    unset inferior_spawn_id

So, now to figure out why those statements are failing....???

                   Carl