public inbox for buildbot@sourceware.org
 help / color / mirror / Atom feed
From: Christophe Lyon <christophe.lyon@arm.com>
To: Mark Wielaard <mark@klomp.org>
Cc: buildbot@sourceware.org, Szabolcs Nagy <Szabolcs.Nagy@arm.com>,
	Luis Machado <Luis.Machado@arm.com>
Subject: Re: Arm GDB buildbot workers
Date: Fri, 8 Jul 2022 12:11:13 +0200	[thread overview]
Message-ID: <ca91cae5-f82f-866d-7e62-bf16793b6996@arm.com> (raw)
In-Reply-To: <Ysdoj05QHX6Kjf2X@wildebeest.org>



On 7/8/22 01:13, Mark Wielaard wrote:
> Hi Christophe,
>
> On Thu, Jul 07, 2022 at 03:50:51PM +0200, Christophe Lyon wrote:
>> As discussed on IRC we are going to enable workers on our Ampere "big"
>> machine.
>>
>> For a start, we are going to try with GDB, having 4 different docker
>> containers on the machine covering ubuntu-20.04/ubuntu-22.04 x
>> arm64/armhf, using 4 CPUs each.
>>
>> I am not sure if we need a single password for all workers, or 4 of them?
>
> You need 4 names, in theory the passwords could be the same for each,
> but I'll sent you 4 names with 4 different passwords (off-list).
>
> Lets name them arm64-ubuntu20_04, arm64-ubuntu22_04, armhf-ubuntu20_04
> and armhf-ubuntu22_04.
>
>> For each of them that means:
>> ncpus:4
>> maxcpus:4
>> max_builds:1
>
> OK. See the attached patch, 4 new workers each connected to a gdb CI
> builder.
>

They are up and running! \o/
I'll probably stop/start them several time to make adjustments like
"admin name".

>> Once these work, I'll add more containers for glibc, binutils and
>> hopefully GCC.
>
> Note that it might be helpful for keeping builds totally separate you
> can use a worker for multiple builders. Depending on the number of
I am not sure to follow?
Why having a worker for multiple builders helps keeping the builds separate?

My plan was to have 1 container running a single worker/builder.
That is 4 containers for 4 GDB "configs (distro x target)", 4 containers
for 4 binutils "configs", X containers for X "configs".

But since these containers would use the same docker image, I think I'll
need to adjust the worker_dir in bb-start.sh, otherwise for instance GDB
and binutils containers/workers/builders would share the same dir, which
won't work (they would compete for the twistd* files etc...)

Do you instead recommend to have 1 (larger) container per distro x
target, and run binutils/GDB/GCC builders inside this single container?

> vcpus and memory available they can do the builds serially or in
> parallal (with max_builds > 1).
>
>> I think this small patch is desirable:
>> diff --git a/builder/containers/bb-start.sh b/builder/containers/bb-start.sh
>> index 31cdbc9..220e82e 100755
>> --- a/builder/containers/bb-start.sh
>> +++ b/builder/containers/bb-start.sh
>> @@ -18,6 +18,7 @@ fi
>>
>>   # Fill in the info visible in the buildbot website
>>   # objcopy gives us the binutils version, iconv the glibc version
>> +mkdir -p $worker_dir/info
>>   echo buildbot@sourceware.org > $worker_dir/info/admin
>>   echo $IMAGE_NAME > $worker_dir/info/host
>>   gcc --version | head -1 >> $worker_dir/info/host
>
> The info dir should have been created by buildbot-worker create-worker.
Indeed, now that I have the proper account/passwd, that works better :-)

>
> BTW. The containers and the bb-start.sh script are somewhat
> over-complicated because they are written to be created and
> instantiated by the buildbot and so have severa layers of abstraction
> that aren't needed if you build the image and start the container
> upfront.
Ack.
They are useful as a starting point.

Thanks,

Christophe

>
> Cheers,
>
> Mark
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

  reply	other threads:[~2022-07-08 10:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-07 13:50 Christophe Lyon
2022-07-07 23:13 ` Mark Wielaard
2022-07-08 10:11   ` Christophe Lyon [this message]
2022-07-08 10:46     ` Mark Wielaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ca91cae5-f82f-866d-7e62-bf16793b6996@arm.com \
    --to=christophe.lyon@arm.com \
    --cc=Luis.Machado@arm.com \
    --cc=Szabolcs.Nagy@arm.com \
    --cc=buildbot@sourceware.org \
    --cc=mark@klomp.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).