public inbox for bunsen@sourceware.org
 help / color / mirror / Atom feed
From: Keith Seitz <keiths@redhat.com>
To: Serhei Makarov <me@serhei.io>, Bunsen <bunsen@sourceware.org>
Subject: Re: Fwd: Re: [PATCH] Introduce simplified grok_architecture function
Date: Wed, 23 Sep 2020 11:14:16 -0700	[thread overview]
Message-ID: <13bf0182-8055-a2d7-bbe7-a8454a948755@redhat.com> (raw)
In-Reply-To: <d8c7e400-fcc2-4af3-8827-64121d6f1f85@www.fastmail.com>

On 9/23/20 6:21 AM, Serhei Makarov wrote:
> (should forward to list)
> 
> ----- Original message -----
> From: Serhei Makarov <me@serhei.io>
> To: Keith Seitz <keiths@redhat.com>
> Subject: Re: [PATCH] Introduce simplified grok_architecture function
> Date: Wednesday, September 23, 2020 9:21 AM
> 
> On Tue, Sep 22, 2020, at 1:58 PM, Keith Seitz via Bunsen wrote:
>> Comments on this apporach?
>>
>> Should I move this to the common module and update systemtap/parse_dejagnu.py?
> LGTM. You can commit as-is, or add to the common module as you suggested.

I did discover one inconsistency between my proposed patch and the current
implementation: native_configuration_map contains a few non-direct mappings
of the architecture name, e.g., "powerpc64le-VENDOR-linux" --> "ppc64le".

I'll adjust the patch and send out a revised copy for review.

> Also, I'm going to make another improvement to a different area of
> the parser that's always been problematic (the code to extract
> osver). I've thought of a solution that should be more general.

Great. I haven't yet looked into that! :-)

Keith


  reply	other threads:[~2020-09-23 18:14 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-23 13:21 Serhei Makarov
2020-09-23 18:14 ` Keith Seitz [this message]
2020-09-23 19:15   ` [PATCH v2] " Keith Seitz
2020-09-23 19:26     ` Serhei Makarov
2020-09-23 19:46       ` Keith Seitz
2020-09-23 22:48         ` Serhei Makarov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=13bf0182-8055-a2d7-bbe7-a8454a948755@redhat.com \
    --to=keiths@redhat.com \
    --cc=bunsen@sourceware.org \
    --cc=me@serhei.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).