From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 71FBD3857C55 for ; Wed, 23 Sep 2020 18:14:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 71FBD3857C55 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-283-MjgiWZPFOYChbrBKzYCucQ-1; Wed, 23 Sep 2020 14:14:18 -0400 X-MC-Unique: MjgiWZPFOYChbrBKzYCucQ-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2EBBC191E2A2; Wed, 23 Sep 2020 18:14:17 +0000 (UTC) Received: from theo.uglyboxes.com (ovpn-113-168.phx2.redhat.com [10.3.113.168]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BB1C13A40; Wed, 23 Sep 2020 18:14:16 +0000 (UTC) Subject: Re: Fwd: Re: [PATCH] Introduce simplified grok_architecture function To: Serhei Makarov , Bunsen References: From: Keith Seitz Message-ID: <13bf0182-8055-a2d7-bbe7-a8454a948755@redhat.com> Date: Wed, 23 Sep 2020 11:14:16 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US X-Spam-Status: No, score=-8.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: bunsen@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Bunsen mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Sep 2020 18:14:22 -0000 On 9/23/20 6:21 AM, Serhei Makarov wrote: > (should forward to list) > > ----- Original message ----- > From: Serhei Makarov > To: Keith Seitz > Subject: Re: [PATCH] Introduce simplified grok_architecture function > Date: Wednesday, September 23, 2020 9:21 AM > > On Tue, Sep 22, 2020, at 1:58 PM, Keith Seitz via Bunsen wrote: >> Comments on this apporach? >> >> Should I move this to the common module and update systemtap/parse_dejagnu.py? > LGTM. You can commit as-is, or add to the common module as you suggested. I did discover one inconsistency between my proposed patch and the current implementation: native_configuration_map contains a few non-direct mappings of the architecture name, e.g., "powerpc64le-VENDOR-linux" --> "ppc64le". I'll adjust the patch and send out a revised copy for review. > Also, I'm going to make another improvement to a different area of > the parser that's always been problematic (the code to extract > osver). I've thought of a solution that should be more general. Great. I haven't yet looked into that! :-) Keith