public inbox for bunsen@sourceware.org
 help / color / mirror / Atom feed
* Fwd: Re: [PATCH] Introduce simplified grok_architecture function
@ 2020-09-23 13:21 Serhei Makarov
  2020-09-23 18:14 ` Keith Seitz
  0 siblings, 1 reply; 6+ messages in thread
From: Serhei Makarov @ 2020-09-23 13:21 UTC (permalink / raw)
  To: Bunsen

(should forward to list)

----- Original message -----
From: Serhei Makarov <me@serhei.io>
To: Keith Seitz <keiths@redhat.com>
Subject: Re: [PATCH] Introduce simplified grok_architecture function
Date: Wednesday, September 23, 2020 9:21 AM

On Tue, Sep 22, 2020, at 1:58 PM, Keith Seitz via Bunsen wrote:
> Comments on this apporach?
> 
> Should I move this to the common module and update systemtap/parse_dejagnu.py?
LGTM. You can commit as-is, or add to the common module as you suggested.

Also, I'm going to make another improvement to a different area of the parser that's always been problematic (the code to extract osver). I've thought of a solution that should be more general.

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2020-09-23 22:49 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-23 13:21 Fwd: Re: [PATCH] Introduce simplified grok_architecture function Serhei Makarov
2020-09-23 18:14 ` Keith Seitz
2020-09-23 19:15   ` [PATCH v2] " Keith Seitz
2020-09-23 19:26     ` Serhei Makarov
2020-09-23 19:46       ` Keith Seitz
2020-09-23 22:48         ` Serhei Makarov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).