From: Keith Seitz <keiths@redhat.com>
To: bunsen@sourceware.org
Subject: [PATCH] Remove grok_architecture call from gdb.commit_logs.commit_logs
Date: Thu, 5 Aug 2021 11:42:11 -0700 [thread overview]
Message-ID: <20210805184211.10976-1-keiths@redhat.com> (raw)
`grok_architecture' is called from gdb's commit_logs function.
However at this moment, we actually can't do anything to ascertain
the architecture. This function is currently passing the `testdir'
variable, which is non-sensical.
Architecture is actually grok'd in annotate_dejagnu_log, so simply
remove the call here.
---
scripts-main/gdb/commit_logs.py | 1 -
1 file changed, 1 deletion(-)
diff --git a/scripts-main/gdb/commit_logs.py b/scripts-main/gdb/commit_logs.py
index a8edb14..1c23c2f 100755
--- a/scripts-main/gdb/commit_logs.py
+++ b/scripts-main/gdb/commit_logs.py
@@ -218,7 +218,6 @@ def commit_logs(b, wd, *args, **kwargs):
gdb_sum = pick_testlog(testdir, tmpdir, 'gdb.sum') # XXX parser autodetects .xz
gdb_log = pick_testlog(testdir, tmpdir, 'gdb.log') # XXX parser autodetects .xz
testrun = parse_README(testrun, gdb_README)
- testrun.arch = grok_architecture(testdir)
testrun.osver = osver
testrun = parse_dejagnu_sum(testrun, gdb_sum, all_cases=all_cases)
testrun = annotate_dejagnu_log(testrun, gdb_log, all_cases, verbose=False)
--
2.31.1
next reply other threads:[~2021-08-05 18:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-05 18:42 Keith Seitz [this message]
2021-08-05 19:28 ` Serhei Makarov
2021-08-05 19:48 ` Keith Seitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210805184211.10976-1-keiths@redhat.com \
--to=keiths@redhat.com \
--cc=bunsen@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).