[PATCH] Remove grok_architecture call from gdb.commit_logs.commit_logs

[PATCH] Remove grok_architecture call from gdb.commit_logs.commit_logs

[Keith Seitz]

`grok_architecture' is called from gdb's commit_logs function.
However at this moment, we actually can't do anything to ascertain
the architecture. This function is currently passing the `testdir'
variable, which is non-sensical.

Architecture is actually grok'd in annotate_dejagnu_log, so simply
remove the call here.
---
 scripts-main/gdb/commit_logs.py | 1 -
 1 file changed, 1 deletion(-)

diff --git a/scripts-main/gdb/commit_logs.py b/scripts-main/gdb/commit_logs.py
index a8edb14..1c23c2f 100755
--- a/scripts-main/gdb/commit_logs.py
+++ b/scripts-main/gdb/commit_logs.py
@@ -218,7 +218,6 @@ def commit_logs(b, wd, *args, **kwargs):
     gdb_sum = pick_testlog(testdir, tmpdir, 'gdb.sum') # XXX parser autodetects .xz
     gdb_log = pick_testlog(testdir, tmpdir, 'gdb.log') # XXX parser autodetects .xz
     testrun = parse_README(testrun, gdb_README)
-    testrun.arch = grok_architecture(testdir)
     testrun.osver = osver
     testrun = parse_dejagnu_sum(testrun, gdb_sum, all_cases=all_cases)
     testrun = annotate_dejagnu_log(testrun, gdb_log, all_cases, verbose=False)
-- 
2.31.1

Re: [PATCH] Remove grok_architecture call from gdb.commit_logs.commit_logs

[Serhei Makarov]

On Thu, Aug 5, 2021, at 2:42 PM, Keith Seitz via Bunsen wrote:
> `grok_architecture' is called from gdb's commit_logs function.
> However at this moment, we actually can't do anything to ascertain
> the architecture. This function is currently passing the `testdir'
> variable, which is non-sensical.
> 
> Architecture is actually grok'd in annotate_dejagnu_log, so simply
> remove the call here.
The history of this line is that I was importing results from Sergio's buildbots,
where they were organized in directory and the name of the directory was the most obvious
(iirc the only) source for some of the arch/distro information.

Looks like this is the result of a messed up refactoring. At some point grok_architecture was
local to commit_logs and did a more flexible match for architecture names.

Therefore, ok to commit the patch. (I'll do it myself later on if you're busy, but it might be
good to test that you have commit access.)

All the best,
      Serhei

Re: [PATCH] Remove grok_architecture call from gdb.commit_logs.commit_logs

[Keith Seitz]

On 8/5/21 12:28 PM, Serhei Makarov wrote:
> 
> Therefore, ok to commit the patch. (I'll do it myself later on if you're busy, but it might be
> good to test that you have commit access.)

Pushed! Apparently there's a psychic overseer out there somewhere. :-)

Thank you,
Keith