From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 560A23858436 for ; Thu, 5 Aug 2021 18:42:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 560A23858436 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-283-dNzU5pyiOLuPaWex0z05ow-1; Thu, 05 Aug 2021 14:42:12 -0400 X-MC-Unique: dNzU5pyiOLuPaWex0z05ow-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C59931800D41 for ; Thu, 5 Aug 2021 18:42:11 +0000 (UTC) Received: from guittard.uglyboxes.com (ovpn-115-36.phx2.redhat.com [10.3.115.36]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9E8621383C for ; Thu, 5 Aug 2021 18:42:11 +0000 (UTC) From: Keith Seitz To: bunsen@sourceware.org Subject: [PATCH] Remove grok_architecture call from gdb.commit_logs.commit_logs Date: Thu, 5 Aug 2021 11:42:11 -0700 Message-Id: <20210805184211.10976-1-keiths@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" X-Spam-Status: No, score=-13.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: bunsen@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Bunsen mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Aug 2021 18:42:19 -0000 `grok_architecture' is called from gdb's commit_logs function. However at this moment, we actually can't do anything to ascertain the architecture. This function is currently passing the `testdir' variable, which is non-sensical. Architecture is actually grok'd in annotate_dejagnu_log, so simply remove the call here. --- scripts-main/gdb/commit_logs.py | 1 - 1 file changed, 1 deletion(-) diff --git a/scripts-main/gdb/commit_logs.py b/scripts-main/gdb/commit_logs.py index a8edb14..1c23c2f 100755 --- a/scripts-main/gdb/commit_logs.py +++ b/scripts-main/gdb/commit_logs.py @@ -218,7 +218,6 @@ def commit_logs(b, wd, *args, **kwargs): gdb_sum = pick_testlog(testdir, tmpdir, 'gdb.sum') # XXX parser autodetects .xz gdb_log = pick_testlog(testdir, tmpdir, 'gdb.log') # XXX parser autodetects .xz testrun = parse_README(testrun, gdb_README) - testrun.arch = grok_architecture(testdir) testrun.osver = osver testrun = parse_dejagnu_sum(testrun, gdb_sum, all_cases=all_cases) testrun = annotate_dejagnu_log(testrun, gdb_log, all_cases, verbose=False) -- 2.31.1