public inbox for bunsen@sourceware.org
 help / color / mirror / Atom feed
From: Keith Seitz <keiths@redhat.com>
To: bunsen@sourceware.org
Subject: [PATCH] r-dejagnu-diff-logs: fix patched-unpatched typo
Date: Mon, 15 Aug 2022 09:28:47 -0700	[thread overview]
Message-ID: <20220815162847.1951605-1-keiths@redhat.com> (raw)

There is a little typo in get_commits() which could (or will) cause the
user some confusion. The unpatched and patched commits are reversed
because of a typo!
---
 bin/r-dejagnu-diff-logs | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/bin/r-dejagnu-diff-logs b/bin/r-dejagnu-diff-logs
index 2297b2a..2e595ae 100755
--- a/bin/r-dejagnu-diff-logs
+++ b/bin/r-dejagnu-diff-logs
@@ -97,8 +97,8 @@ def get_commits(testruns, args):
     unpatched_commit = None
     patched_commit = None
     try:
-        unpatched_commit = testruns.commit(args.patched)
-        patched_commit = testruns.commit(args.unpatched)
+        unpatched_commit = testruns.commit(args.unpatched)
+        patched_commit = testruns.commit(args.patched)
     except Exception as e:
         pass
     return (unpatched_commit, patched_commit)
-- 
2.36.1


             reply	other threads:[~2022-08-15 16:28 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-15 16:28 Keith Seitz [this message]
2022-08-22 16:10 ` Keith Seitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220815162847.1951605-1-keiths@redhat.com \
    --to=keiths@redhat.com \
    --cc=bunsen@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).