public inbox for bunsen@sourceware.org
 help / color / mirror / Atom feed
From: "Serhei Makarov" <me@serhei.io>
To: "Carley Gilmore" <cgilmore@redhat.com>, Bunsen <bunsen@sourceware.org>
Subject: Re: [PATCH] Fix in model.py Testrun class for self instance of summary
Date: Fri, 18 Jun 2021 15:33:59 -0400	[thread overview]
Message-ID: <3ade64ee-31a7-42d8-919c-ce1597ae137a@www.fastmail.com> (raw)
In-Reply-To: <20210617173428.950882-1-cgilmore@redhat.com>

Patch LGTM, applied yesterday

https://sourceware.org/git/?p=bunsen.git;a=commit;h=d12304a5af3bf228a3c48d8529560c2f28e491e6

Thanks for the fix!

On Thu, Jun 17, 2021, at 1:34 PM, Carley Gilmore via Bunsen wrote:
> ---
>  bunsen/model.py | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/bunsen/model.py b/bunsen/model.py
> index 0fa09f4..7299811 100644
> --- a/bunsen/model.py
> +++ b/bunsen/model.py
> @@ -1178,7 +1178,7 @@ class Testrun(dict):
>              if field not in self.field_types:
>                  pass
>              elif self.field_types[field] == 'testcases' \
> -                and summary:
> +                and self.summary:
>                  continue # omit testcases when reading only summary
>              elif self.field_types[field] == 'testcases':
>                  defer_fields.append(field)
> @@ -1189,7 +1189,7 @@ class Testrun(dict):
>                      .format(self.field_types[field], field))
>              else:
>                  pass # no special processing needed
> -            if summary and field == 'testcases':
> +            if self.summary and field == 'testcases':
>                  continue # omit testcases when reading only summary
>              if field in self._cursor_commit_ids:
>                  self._cursor_commit_ids[field] = value
> -- 
> 2.31.1
> 
> 

      reply	other threads:[~2021-06-18 19:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-17 17:34 Carley Gilmore
2021-06-18 19:33 ` Serhei Makarov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3ade64ee-31a7-42d8-919c-ce1597ae137a@www.fastmail.com \
    --to=me@serhei.io \
    --cc=bunsen@sourceware.org \
    --cc=cgilmore@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).