* [PATCH] Fix in model.py Testrun class for self instance of summary
@ 2021-06-17 17:34 Carley Gilmore
2021-06-18 19:33 ` Serhei Makarov
0 siblings, 1 reply; 2+ messages in thread
From: Carley Gilmore @ 2021-06-17 17:34 UTC (permalink / raw)
To: bunsen; +Cc: Carley Gilmore
---
bunsen/model.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/bunsen/model.py b/bunsen/model.py
index 0fa09f4..7299811 100644
--- a/bunsen/model.py
+++ b/bunsen/model.py
@@ -1178,7 +1178,7 @@ class Testrun(dict):
if field not in self.field_types:
pass
elif self.field_types[field] == 'testcases' \
- and summary:
+ and self.summary:
continue # omit testcases when reading only summary
elif self.field_types[field] == 'testcases':
defer_fields.append(field)
@@ -1189,7 +1189,7 @@ class Testrun(dict):
.format(self.field_types[field], field))
else:
pass # no special processing needed
- if summary and field == 'testcases':
+ if self.summary and field == 'testcases':
continue # omit testcases when reading only summary
if field in self._cursor_commit_ids:
self._cursor_commit_ids[field] = value
--
2.31.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Fix in model.py Testrun class for self instance of summary
2021-06-17 17:34 [PATCH] Fix in model.py Testrun class for self instance of summary Carley Gilmore
@ 2021-06-18 19:33 ` Serhei Makarov
0 siblings, 0 replies; 2+ messages in thread
From: Serhei Makarov @ 2021-06-18 19:33 UTC (permalink / raw)
To: Carley Gilmore, Bunsen
Patch LGTM, applied yesterday
https://sourceware.org/git/?p=bunsen.git;a=commit;h=d12304a5af3bf228a3c48d8529560c2f28e491e6
Thanks for the fix!
On Thu, Jun 17, 2021, at 1:34 PM, Carley Gilmore via Bunsen wrote:
> ---
> bunsen/model.py | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/bunsen/model.py b/bunsen/model.py
> index 0fa09f4..7299811 100644
> --- a/bunsen/model.py
> +++ b/bunsen/model.py
> @@ -1178,7 +1178,7 @@ class Testrun(dict):
> if field not in self.field_types:
> pass
> elif self.field_types[field] == 'testcases' \
> - and summary:
> + and self.summary:
> continue # omit testcases when reading only summary
> elif self.field_types[field] == 'testcases':
> defer_fields.append(field)
> @@ -1189,7 +1189,7 @@ class Testrun(dict):
> .format(self.field_types[field], field))
> else:
> pass # no special processing needed
> - if summary and field == 'testcases':
> + if self.summary and field == 'testcases':
> continue # omit testcases when reading only summary
> if field in self._cursor_commit_ids:
> self._cursor_commit_ids[field] = value
> --
> 2.31.1
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-06-18 19:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-17 17:34 [PATCH] Fix in model.py Testrun class for self instance of summary Carley Gilmore
2021-06-18 19:33 ` Serhei Makarov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).