From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 58EDA3857C52 for ; Thu, 24 Sep 2020 17:47:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 58EDA3857C52 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-563-zax3iOZYPzicGYBT3oiQqg-1; Thu, 24 Sep 2020 13:47:35 -0400 X-MC-Unique: zax3iOZYPzicGYBT3oiQqg-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 62C76107465F; Thu, 24 Sep 2020 17:47:34 +0000 (UTC) Received: from theo.uglyboxes.com (ovpn-113-168.phx2.redhat.com [10.3.113.168]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D8D3D1002C08; Thu, 24 Sep 2020 17:47:33 +0000 (UTC) Subject: Re: Fwd: Re: [PATCH] Use binary mode to read .log/.sum To: Serhei Makarov , Bunsen References: <97957952-514b-4186-9cac-93fe07517309@www.fastmail.com> From: Keith Seitz Message-ID: <4e5b855d-689d-6218-0df9-0174d5e87cdf@redhat.com> Date: Thu, 24 Sep 2020 10:47:33 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <97957952-514b-4186-9cac-93fe07517309@www.fastmail.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-8.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: bunsen@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Bunsen mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Sep 2020 17:47:39 -0000 On 9/23/20 6:00 PM, Serhei Makarov wrote: > In retrospect, the need to deal with encodings is a major annoyance > about I/O in recent Python versions. I have had to make prior fixes > for similar issues, and I'm unsurprised that there is still more to > fix. I hear ya. Since I am no python expert, I just did some web searching about the subject. This was the most recommended approach. Thanks for the look -- patch pushed. Keith