From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout-p-202.mailbox.org (mout-p-202.mailbox.org [IPv6:2001:67c:2050:0:465::202]) by sourceware.org (Postfix) with ESMTPS id 7EBD03858D35; Wed, 18 Jan 2023 00:23:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7EBD03858D35 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=aarsen.me Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=aarsen.me Received: from smtp102.mailbox.org (smtp102.mailbox.org [10.196.197.102]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-202.mailbox.org (Postfix) with ESMTPS id 4NxRLy4Y75z9sv4; Wed, 18 Jan 2023 01:23:38 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aarsen.me; s=MBO0001; t=1674001418; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rt7OuZCzpaZBde0Ltzq0C4P4SCSFUaG3jJxzHjD0o6s=; b=JfOP2vzBA7JxaTo9J7/hQPFHH081VlJV/dqjPxYpPtNqwWacwQFmL6S+NYRlT1liyEZnJ/ AiBRz1X6jqkM1Cz0uXROozlrT9caQg9otidqbxZdq4DHReAej5Y9ZwhoHFh9zyPnknUM2/ AfzJMQygS2c3uGgX/8yL42wCtgs+EgV4x4KroReZtVdORSrMN2BbCS1Kx2EBCMFhGUWREM ENh/5V6C70VBKecHAYu+2VpjiejyjPuxmwhrrt2dbF0J19LDOIIEsJQmd/9PG4cVluhlx1 yRGsAWlhEm6OqfZPlVsqvLzD8rR6WfyJBrRsa+XDKFy+r00nqnihx8Ty6Wfmrg== References: <86sfg8iw7d.fsf@aarsen.me> <20230117235107.GC10730@redhat.com> From: Arsen =?utf-8?Q?Arsenovi=C4=87?= To: "Frank Ch. Eigler" Cc: bunsen@sourceware.org, builder@sourceware.org Subject: Re: Automake dist-check and log extraction: runtest --outdir Date: Wed, 18 Jan 2023 00:57:25 +0100 In-reply-to: <20230117235107.GC10730@redhat.com> Message-ID: <86ilh4itbq.fsf@aarsen.me> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_INFOUSMEBIZ,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable "Frank Ch. Eigler" writes: > Hi - > >> The make_distcheck_test_suite_step uses a logfiles=3D keyword arg, which >> in turn uses inotify (presumably) to watch a file for a logfile creatd >> on it, and to collect info from it. > > buildbot buildbot_worker runprocess.py appears to use fstat > ctime/mtime/size polling to query in-progress files. Ah, okay. I couldn't find where exactly it was implemented, so I took that shot in the dark :) > bunsen only collects final files. > >> [...] >> DejaGnu provides a way for the directory in which log and sum files are >> stored to be altered, see --outdir in >> [...] >> This, indeed, resulted in a poke.log and poke.sum in the /tmp/outtest >> directory. >> I believe we should replace the inotify-based mechanism with this method >> of redirecting logs. > > I'm afraid I don't quite understand how this should improve on > anything, even if buildbot-worker were to use inotify instead of fstat > polling. It's just a different pathname for the files. Yes, but they could, as a result, land outside of distchecks rm -r jurisdiction. I didn't mean to emphasize the role of inotify at all, rather the role of distchecks cleanup of the build directory, which acts as a limit on the lifetime of the testsuite results file. The builder could avoid testsuite files being deleted altogether by specifying an outdir outside of distchecks temporary directory. ... but maybe I'm overthinking this. The buildbot worker holds the file open and just reads new data as it gets appended to the file, which should be enough to keep the file alive after rm gets to it, so the only edge case might be that distcheck could somehow conclude in less time than the polling period, assuming that LoopingCall#start delays first invocation, or otherwise that the log files might be created and cleaned up inbetween poll intervals. =2D-=20 Arsen Arsenovi=C4=87 --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iOYEARYKAI4WIQT+4rPRE/wAoxYtYGFSwpQwHqLEkwUCY8c8CV8UgAAAAAAuAChp c3N1ZXItZnByQG5vdGF0aW9ucy5vcGVucGdwLmZpZnRoaG9yc2VtYW4ubmV0RkVF MkIzRDExM0ZDMDBBMzE2MkQ2MDYxNTJDMjk0MzAxRUEyQzQ5MxAcYXJzZW5AYWFy c2VuLm1lAAoJEFLClDAeosSTHhcBAKXeop7nc3jZYmhJrr2chF5S9vG1YO4wD1KN H63943U7AP0XK7QuZrVXW1/XUWIohj0Wmp0V2/X15CpRDsBJlCONBA== =HO69 -----END PGP SIGNATURE----- --=-=-=--