From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by sourceware.org (Postfix) with ESMTP id 474493857C7A for ; Wed, 23 Sep 2020 19:46:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 474493857C7A Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-8-ifALw9YRO7KvI8ztVFE6Jw-1; Wed, 23 Sep 2020 15:46:05 -0400 X-MC-Unique: ifALw9YRO7KvI8ztVFE6Jw-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 26C2E85EE96; Wed, 23 Sep 2020 19:46:04 +0000 (UTC) Received: from theo.uglyboxes.com (ovpn-113-168.phx2.redhat.com [10.3.113.168]) by smtp.corp.redhat.com (Postfix) with ESMTPS id ED1087368B; Wed, 23 Sep 2020 19:46:03 +0000 (UTC) Subject: Re: [PATCH v2] Introduce simplified grok_architecture function To: Serhei Makarov Cc: Bunsen References: <13bf0182-8055-a2d7-bbe7-a8454a948755@redhat.com> <20200923191517.1467231-1-keiths@redhat.com> <6e7c5822-19a1-4a36-a88e-ba3a99b3af4d@www.fastmail.com> From: Keith Seitz Message-ID: Date: Wed, 23 Sep 2020 12:46:03 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <6e7c5822-19a1-4a36-a88e-ba3a99b3af4d@www.fastmail.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-8.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: bunsen@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Bunsen mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Sep 2020 19:46:10 -0000 On 9/23/20 12:26 PM, Serhei Makarov wrote: >> - native_configuration_is = None >> + testrun.arch = None > >> + if testrun.arch is None and line.startswith("Native >> configuration is"): >> + testrun.arch = grok_architecture(line) > I would set uname_machine at this point and keep the 'testrun.arch = > uname_machine' assignment in the block at the bottom. I've reverted those hunks (more or less) to maintain that style and pushed the resulting patch. Thanks! Keith