From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by sourceware.org (Postfix) with ESMTPS id 0F6583954424 for ; Wed, 23 Sep 2020 13:22:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 0F6583954424 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=serhei.io Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=me@serhei.io Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id 8E45286E for ; Wed, 23 Sep 2020 09:22:16 -0400 (EDT) Received: from imap21 ([10.202.2.71]) by compute7.internal (MEProxy); Wed, 23 Sep 2020 09:22:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=serhei.io; h= mime-version:message-id:date:from:to:subject:content-type; s= fm2; bh=W+cXdPVGYXmXMQLYSN0GJNtrbxAsCSUjfFd4MQOGgno=; b=0UTEIMjF bgRT+osGIXkrO2pJ8UfKvm5bwLyMV+9Tk+zHvhgGFhjeWZny5pnQt46Q78+PD3a+ k3+E0A04bJwOTIcW+WSnGW9ewRgIRynqTnJYzdPOKxb3IasFaefO3KESJxYrYoSh hL8H7oRI4vf2vZ3qg7m8nhTxZgH8tfS7PwmEUOZXMowo5pEsu98dtpbrVJ9A8IqB +D71eLC2OCzawwYxIuNL4oTLFWYYmILZ852w7k3FgPMqquwcue4ZHCzI1POP4NSo 0olLyixM3lFao4rjfLKbWgouyncBeAIKHSeyognddu7/klr8FuqGe2qceRMXhQvD gXaRvCHGpGcL/g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:message-id :mime-version:subject:to:x-me-proxy:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm3; bh=W+cXdPVGYXmXMQLYSN0GJNtrbxAsC SUjfFd4MQOGgno=; b=B+fWwoHH6zHYgvWk4ZYC5xK+ySwTccvCXOvSvZNNS5nba fAOSkApy5M1oEWw+v/1Cil9sceJxFhBlBzzAx+pWjEQ8gjVlCtPJwzIAAW+f+iAm R6bKlUfSsf3DyO2OCuYBGrtYBIJQgCTukhC4JqkgQ9373sbEfhxUsMBL6LjWo/nX uioOCNkAwxKuOXXZTbEf9f/sRwO1wA7uDZighLMYqlxIGE0+TGjP8PaU2n08vdYh bcC8ppaQbxPoIL0ZBBa6YpUMZGdT/SDgOQMCYFOviuIvUXUpxvRTDXuL6v8VeqQM YSGQYjP/m2HYnYObsRptpms1NZM89wCU+AKDQqa7w== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudeigdeihecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhepofgfggfkfffhvffutgesthdtredtre ertdenucfhrhhomhepfdfuvghrhhgvihcuofgrkhgrrhhovhdfuceomhgvsehsvghrhhgv ihdrihhoqeenucggtffrrghtthgvrhhnpeeiveduleeivdefueevfeefgffgleethfeive evieegudeuffetjeevfefhtdehleenucffohhmrghinhepuggvjhgrghhnuhdrphihnecu vehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhgvsehsvg hrhhgvihdrihho X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id 679B766006F; Wed, 23 Sep 2020 09:22:08 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.3.0-355-g3ece53b-fm-20200922.004-g3ece53b9 Mime-Version: 1.0 x-forwarded-message-id: Message-Id: Date: Wed, 23 Sep 2020 09:21:55 -0400 From: "Serhei Makarov" To: Bunsen Subject: Fwd: Re: [PATCH] Introduce simplified grok_architecture function Content-Type: text/plain X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: bunsen@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Bunsen mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Sep 2020 13:22:21 -0000 (should forward to list) ----- Original message ----- From: Serhei Makarov To: Keith Seitz Subject: Re: [PATCH] Introduce simplified grok_architecture function Date: Wednesday, September 23, 2020 9:21 AM On Tue, Sep 22, 2020, at 1:58 PM, Keith Seitz via Bunsen wrote: > Comments on this apporach? > > Should I move this to the common module and update systemtap/parse_dejagnu.py? LGTM. You can commit as-is, or add to the common module as you suggested. Also, I'm going to make another improvement to a different area of the parser that's always been problematic (the code to extract osver). I've thought of a solution that should be more general.