From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id A3323385841A for ; Thu, 5 Aug 2021 19:45:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A3323385841A Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-583-o_nys46qMtuX2o3rqEif7g-1; Thu, 05 Aug 2021 15:45:11 -0400 X-MC-Unique: o_nys46qMtuX2o3rqEif7g-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D1EFB801FCD; Thu, 5 Aug 2021 19:45:09 +0000 (UTC) Received: from [10.3.115.36] (ovpn-115-36.phx2.redhat.com [10.3.115.36]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7296D2B399; Thu, 5 Aug 2021 19:45:09 +0000 (UTC) Subject: Re: [PATCH] When importing results from a full GDB test run, bunsen will throw a TypeError: To: Serhei Makarov , Bunsen References: <20210805190333.11594-1-keiths@redhat.com> <02e91f33-8277-4380-bac6-cae9c7749862@www.fastmail.com> From: Keith Seitz Message-ID: Date: Thu, 5 Aug 2021 12:45:08 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <02e91f33-8277-4380-bac6-cae9c7749862@www.fastmail.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: bunsen@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Bunsen mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Aug 2021 19:45:13 -0000 On 8/5/21 12:39 PM, Serhei Makarov wrote: > Hmm, I could have sworn I dealt with this before... > If outcome_lines contains a malformed line, that's actually a bug. > The previous parser function (parse_dejagnu_log) contains a variable > called all_cases, which should accumulate lines of the form > "OUTCOME: TESTFILE: TESTNAME" only. OMG, I completely overlooked that. Consider this patch (as it is) withdrawn. I'll dig into it again. Thank you! Keith