From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by sourceware.org (Postfix) with ESMTP id 45D4C3857C66 for ; Mon, 21 Sep 2020 20:16:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 45D4C3857C66 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-413-KVROaY4FMPyZ-W11NCN0ow-1; Mon, 21 Sep 2020 16:16:44 -0400 X-MC-Unique: KVROaY4FMPyZ-W11NCN0ow-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1F45E1868405; Mon, 21 Sep 2020 20:16:43 +0000 (UTC) Received: from theo.uglyboxes.com (ovpn-113-168.phx2.redhat.com [10.3.113.168]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C5D2F55765; Mon, 21 Sep 2020 20:16:42 +0000 (UTC) Subject: Re: Initial findings of bunsen performance and questions To: Serhei Makarov Cc: Bunsen References: <30950cc2-5d7f-eb93-42b1-d1c7a9138e81@redhat.com> <9709c97e-bb12-48dd-2c5c-a9efb35e55d1@redhat.com> <8e645045-04e6-412d-97d2-46a173d2fefa@www.fastmail.com> From: Keith Seitz Message-ID: Date: Mon, 21 Sep 2020 13:16:42 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <8e645045-04e6-412d-97d2-46a173d2fefa@www.fastmail.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US X-Spam-Status: No, score=-8.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: bunsen@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Bunsen mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Sep 2020 20:16:49 -0000 On 9/21/20 1:08 PM, Serhei Makarov wrote: > For the record: as I understood, you wanted to store individual testcases > (consolidate_pass=False) since you wanted to have a Cursor giving the line > range for every passing testcase in the .log. Yes, that's correct. > So fixing the Cursor deserialization performance is really necessary. > > Thankfully, it's possible to make the regexp parsing into an on-demand operation > that occurs when a particular Cursor's line_start/line_end/testlog fields are accessed. > commit 2ed3d13f76c3 should solve the issue, reducing the observed 58sec parsing time to 2s. > https://sourceware.org/git/?p=bunsen.git;a=commitdiff;h=2ed3d13f76c37418cfd4180b149bca0e533ec92f > Awesome. That fixes things nicely (and sufficiently). I think this will simplify the API design/implementation for database-based use cases. Thanks, Keith