From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 89368 invoked by alias); 9 Jul 2019 21:12:00 -0000 Mailing-List: contact bzip2-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Subscribe: List-Id: Sender: bzip2-devel-owner@sourceware.org Received: (qmail 89357 invoked by uid 89); 9 Jul 2019 21:11:59 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.100.3 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-19.0 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.1 spammy=straight X-Spam-Status: No, score=-19.0 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on sourceware.org X-Spam-Level: X-HELO: gnu.wildebeest.org Message-ID: <03e0c9b1537ea400554213a7caef8855cc73aa04.camel@klomp.org> Subject: Re: _stati64 patch (Was: [PATCH] Fix include path separator) From: Mark Wielaard To: Joshua Watt Cc: bzip2-devel@sourceware.org, Phil Ross Date: Tue, 01 Jan 2019 00:00:00 -0000 In-Reply-To: <5867f77d-36b1-5ae2-1b53-5e1ee5a63323@gmail.com> References: <20190702200544.27137-1-JPEW.hacker@gmail.com> <20190705083857.GF4777@wildebeest.org> <5867f77d-36b1-5ae2-1b53-5e1ee5a63323@gmail.com> Content-Type: multipart/mixed; boundary="=-Ld62/duE5xdsqVPpRoGy" X-Mailer: Evolution 3.28.5 (3.28.5-2.el7) Mime-Version: 1.0 X-Spam-Flag: NO X-SW-Source: 2019-q3/txt/msg00018.txt.bz2 --=-Ld62/duE5xdsqVPpRoGy Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Content-length: 1424 Hi Joshua, On Tue, 2019-07-09 at 10:00 -0500, Joshua Watt wrote: > On 7/5/19 3:38 AM, Mark Wielaard wrote: > > There is another Windows specific patch which we haven't applied yet > > to the 1.0.x branch because we don't have Windows builders/testers. > >=20 > > It is the attached patch from Phil Ross (CCed) to use _stati64 instead > > of _stat to support large >4GB files on Windows. > >=20 > > If you could test the above works on your setups that would be > > appreciated. Do we need any checks to see whether _stati64 is > > available? Or can it be used unconditionally as in this patch? >=20 > The patch compiles without issues using msvc 18.0 (Visual Studio 2013)=20 > and 64-bit MinGW gcc 7.3.0. 'make test' passes also. Thanks for the extra testing. Lets apply this patch then. It would be good to be able to handle large files on Windows too. > The "patch in a patch" format was a little confusing at first :) Oops, sorry, I wanted to make sure I cherry-picked the original patch from Phil, but in doing so, I got the patch-in-patch variant. I applied the straight diff one (as attached) so that the source matches what was applied on the 1.1.x branch. BTW. I don't know much about windows, and I assume it doesn't ship with bash. But maybe you could take a peek at the bzip2-tests repository and see if you could somehow make that work on Windows? https://sourceware.org/git/bzip2-tests.git Cheers, Mark --=-Ld62/duE5xdsqVPpRoGy Content-Disposition: inline; filename*0=0001-Fix-a-not-a-normal-file-error-when-compressing-large.pat; filename*1=ch Content-Type: text/x-patch; name="0001-Fix-a-not-a-normal-file-error-when-compressing-large.patch"; charset="UTF-8" Content-Transfer-Encoding: base64 Content-length: 1330 RnJvbSAxM2Q4YmNlMDM5M2NhMjFjYmNhMWU4YmE3NjkyNDY2YTY0ZmQ0NmRk IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsIFJvc3MgPHBo aWwucm9zc0BnbWFpbC5jb20+CkRhdGU6IFR1ZSwgMjEgTWF5IDIwMTkgMjA6 NDY6MTQgKzAxMDAKU3ViamVjdDogW1BBVENIXSBGaXggYSAnbm90IGEgbm9y bWFsIGZpbGUnIGVycm9yIHdoZW4gY29tcHJlc3NpbmcgbGFyZ2UgZmlsZXMu CgpUaGUgYnppcDIgY29tbWFuZCBsaW5lIHdvdWxkIHJlcG9ydCAnbm90IGEg bm9ybWFsIGZpbGUnIGZvciBmaWxlcyBvZgpzaXplIGxhcmdlciB0aGFuIDJe MzIgLSAxIGJ5dGVzLgoKUGF0Y2ggYnppcDIuYyB0byB1c2UgX3N0YXRpNjQg aW5zdGVhZCBvZiBfc3RhdCBzbyB0aGF0IGEgc3VjY2Vzc2Z1bApyZXN1bHQg aXMgcmV0dXJuZWQgZm9yIGxhcmdlIGZpbGVzLgoKUmVzb2x2ZXMgaHR0cHM6 Ly9naXRodWIuY29tL3BoaWxyL2J6aXAyLXdpbmRvd3MvaXNzdWVzLzMuCi0t LQogYnppcDIuYyB8IDQgKystLQogMSBmaWxlIGNoYW5nZWQsIDIgaW5zZXJ0 aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9iemlwMi5j IGIvYnppcDIuYwppbmRleCBiZTNiM2JlLi43NmM2Yzk0IDEwMDY0NAotLS0g YS9iemlwMi5jCisrKyBiL2J6aXAyLmMKQEAgLTEzMiw4ICsxMzIsOCBAQAog CiAjICAgZGVmaW5lIE5PUkVUVVJOICAgICAgIC8qKi8KICMgICBkZWZpbmUg UEFUSF9TRVAgICAgICAgJ1xcJwotIyAgIGRlZmluZSBNWV9MU1RBVCAgICAg ICBfc3RhdAotIyAgIGRlZmluZSBNWV9TVEFUICAgICAgICBfc3RhdAorIyAg IGRlZmluZSBNWV9MU1RBVCAgICAgICBfc3RhdGk2NAorIyAgIGRlZmluZSBN WV9TVEFUICAgICAgICBfc3RhdGk2NAogIyAgIGRlZmluZSBNWV9TX0lTUkVH KHgpICAoKHgpICYgX1NfSUZSRUcpCiAjICAgZGVmaW5lIE1ZX1NfSVNESVIo eCkgICgoeCkgJiBfU19JRkRJUikKIAotLSAKMS44LjMuMQoK --=-Ld62/duE5xdsqVPpRoGy--