public inbox for bzip2-devel@sourceware.org
 help / color / mirror / Atom feed
From: Joshua Watt <jpewhacker@gmail.com>
To: Mark Wielaard <mark@klomp.org>
Cc: bzip2-devel@sourceware.org, Phil Ross <phil.ross@gmail.com>
Subject: Re: _stati64 patch (Was: [PATCH] Fix include path separator)
Date: Tue, 01 Jan 2019 00:00:00 -0000	[thread overview]
Message-ID: <047e4d94-9223-b411-bc83-429ba458fa67@gmail.com> (raw)
In-Reply-To: <03e0c9b1537ea400554213a7caef8855cc73aa04.camel@klomp.org>


On 7/9/19 4:11 PM, Mark Wielaard wrote:
> Hi Joshua,
>
> On Tue, 2019-07-09 at 10:00 -0500, Joshua Watt wrote:
>> On 7/5/19 3:38 AM, Mark Wielaard wrote:
>>> There is another Windows specific patch which we haven't applied yet
>>> to the 1.0.x branch because we don't have Windows builders/testers.
>>>
>>> It is the attached patch from Phil Ross (CCed) to use _stati64 instead
>>> of _stat to support large >4GB files on Windows.
>>>
>>> If you could test the above works on your setups that would be
>>> appreciated.  Do we need any checks to see whether _stati64 is
>>> available? Or can it be used unconditionally as in this patch?
>> The patch compiles without issues using msvc 18.0 (Visual Studio 2013)
>> and 64-bit MinGW gcc 7.3.0. 'make test' passes also.
> Thanks for the extra testing. Lets apply this patch then.
> It would be good to be able to handle large files on Windows too.
>
>> The "patch in a patch" format was a little confusing at first :)
> Oops, sorry, I wanted to make sure I cherry-picked the original patch
> from Phil, but in doing so, I got the patch-in-patch variant. I applied
> the straight diff one (as attached) so that the source matches what was
> applied on the 1.1.x branch.
>
> BTW. I don't know much about windows, and I assume it doesn't ship with
> bash. But maybe you could take a peek at the bzip2-tests repository and
> see if you could somehow make that work on Windows?
> https://sourceware.org/git/bzip2-tests.git

Windows isn't really my preferred OS either; I'm tasked with maintaining 
an embedded Linux cross compiling environment for Windows as part of my 
day job, so I end up dealing with it more that I would perhaps like :)

Anyway, the good news is that you don't really need to make any changes 
to the bzip2-tests repo; it works fine on Windows as is. As previously 
stated, I compiled bzip2 using MinGW (http://www.mingw.org/). There is 
also a related project called msys (http://www.mingw.org/wiki/MSYS) that 
will give you a traditional bash shell (as well as most other standard 
utilities) in Windows. The run-tests.sh script works just fine there and 
all the tests pass, using a build of bzip2 from b07b105 ("Accept as many 
selectors as the file format allows.").


>
> Cheers,
>
> Mark

  reply	other threads:[~2019-07-09 21:59 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-01  0:00 [PATCH] Fix include path separator Joshua Watt
2019-01-01  0:00 ` Mark Wielaard
     [not found]   ` <CAJdd5GZfTk8EKeUE_C1keKm+gn=qapv9OQGGariiiXP9jyu0wQ@mail.gmail.com>
2019-01-01  0:00     ` _stati64 patch (Was: [PATCH] Fix include path separator) Mark Wielaard
2019-01-01  0:00       ` Joshua Watt
2019-01-01  0:00         ` Mark Wielaard
2019-01-01  0:00           ` Joshua Watt [this message]
2019-01-01  0:00             ` Mark Wielaard
2019-01-01  0:00               ` Joshua Watt
2019-01-01  0:00                 ` Mark Wielaard
2019-01-01  0:00                   ` Joshua Watt
2019-01-01  0:00     ` [PATCH] Fix include path separator Mark Wielaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=047e4d94-9223-b411-bc83-429ba458fa67@gmail.com \
    --to=jpewhacker@gmail.com \
    --cc=bzip2-devel@sourceware.org \
    --cc=mark@klomp.org \
    --cc=phil.ross@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).