From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 114458 invoked by alias); 9 Jul 2019 21:59:17 -0000 Mailing-List: contact bzip2-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Subscribe: List-Id: Sender: bzip2-devel-owner@sourceware.org Received: (qmail 114438 invoked by uid 89); 9 Jul 2019 21:59:17 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.100.3 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.4 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy= X-Spam-Status: No, score=-0.4 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on sourceware.org X-Spam-Level: X-HELO: mail-io1-f67.google.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:subject:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=tlWCAYITjr9h+EckEUbG5iWBmreWqB/znV06VIoSnPw=; b=rr53qz5U0A+4rnAyWZHMKyXsPSN4+fDA1r6iGFBNNawRsFEeZBQlYOt6+761OVv5Ld y541SPmqHvTqlzczZY5Pq/TpDhmjK0QEglIRlc9YepJlFNbeJDRgjhnI+9fc+NRqmtTC kyNGaU0yhWlgCvCgOs6uYOYMxoHgIu3xb0TI5xSzl+sAo+IYcajI/M58qJ2V11WdD8X+ N4TWPjeHwVKyFAI8P6NGKDJw+kruS07wUyWHi54cyhvtOwxDU8t4Heu6HKevMKsCrXZy Oa4WwYrYgijgewpUu1EAUY6FrBIR19f5G2uAbf9k9drfiaJS/JRTn+npA/F6glCxIPRa gsoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:subject:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=tlWCAYITjr9h+EckEUbG5iWBmreWqB/znV06VIoSnPw=; b=kfa1tegZeNBkEL8jAffcDNIRdxqIe2BL9pFfp5gLPhNniAjCwI8nHRHw6AdUL3InD/ 4MHv9CTbgNU66H/kQb9Ov0JiG1zmLiuVNCvCC137tIvDwfKtZKaCbIzgRGHTMwPlIJu8 a8NScL3BSfKywF0i8IN13JKfKFOpxRfJyW4ozTDYqi43B+401IGxd34DK0bW6Ce/pfG4 8emXcmc1iZ9YSW0pYmXhF1F+VTS3p9grbCFdMHBeAdRZ5ro9ag5UGN846zxVpX6qGQwF crOv5nmRnpWSseHqB4MRM6H611hahu0DO9cXZguqi7CfxOxVXSce5lTOx5pSjsiwDJz3 8Jbw== X-Gm-Message-State: APjAAAVhxNnI0KNoq83wCBVbIp0+I+Sp3arAg3cGSTvQ7P/2tNe+17et waTWUSmTO4oh+rmxk2ax4Js= X-Google-Smtp-Source: APXvYqwGtYFTCPCnvMajK09sUdmhlrg0xhJmYkD1jgWJ58LNWgrj2w7rC7Lj1w0axtVFq1sZ6dKZUQ== X-Received: by 2002:a5d:8794:: with SMTP id f20mr18531528ion.128.1562709553658; Tue, 09 Jul 2019 14:59:13 -0700 (PDT) From: Joshua Watt X-Google-Original-From: Joshua Watt Subject: Re: _stati64 patch (Was: [PATCH] Fix include path separator) To: Mark Wielaard Cc: bzip2-devel@sourceware.org, Phil Ross References: <20190702200544.27137-1-JPEW.hacker@gmail.com> <20190705083857.GF4777@wildebeest.org> <5867f77d-36b1-5ae2-1b53-5e1ee5a63323@gmail.com> <03e0c9b1537ea400554213a7caef8855cc73aa04.camel@klomp.org> Message-ID: <047e4d94-9223-b411-bc83-429ba458fa67@gmail.com> Date: Tue, 01 Jan 2019 00:00:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <03e0c9b1537ea400554213a7caef8855cc73aa04.camel@klomp.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-SW-Source: 2019-q3/txt/msg00020.txt.bz2 On 7/9/19 4:11 PM, Mark Wielaard wrote: > Hi Joshua, > > On Tue, 2019-07-09 at 10:00 -0500, Joshua Watt wrote: >> On 7/5/19 3:38 AM, Mark Wielaard wrote: >>> There is another Windows specific patch which we haven't applied yet >>> to the 1.0.x branch because we don't have Windows builders/testers. >>> >>> It is the attached patch from Phil Ross (CCed) to use _stati64 instead >>> of _stat to support large >4GB files on Windows. >>> >>> If you could test the above works on your setups that would be >>> appreciated. Do we need any checks to see whether _stati64 is >>> available? Or can it be used unconditionally as in this patch? >> The patch compiles without issues using msvc 18.0 (Visual Studio 2013) >> and 64-bit MinGW gcc 7.3.0. 'make test' passes also. > Thanks for the extra testing. Lets apply this patch then. > It would be good to be able to handle large files on Windows too. > >> The "patch in a patch" format was a little confusing at first :) > Oops, sorry, I wanted to make sure I cherry-picked the original patch > from Phil, but in doing so, I got the patch-in-patch variant. I applied > the straight diff one (as attached) so that the source matches what was > applied on the 1.1.x branch. > > BTW. I don't know much about windows, and I assume it doesn't ship with > bash. But maybe you could take a peek at the bzip2-tests repository and > see if you could somehow make that work on Windows? > https://sourceware.org/git/bzip2-tests.git Windows isn't really my preferred OS either; I'm tasked with maintaining an embedded Linux cross compiling environment for Windows as part of my day job, so I end up dealing with it more that I would perhaps like :) Anyway, the good news is that you don't really need to make any changes to the bzip2-tests repo; it works fine on Windows as is. As previously stated, I compiled bzip2 using MinGW (http://www.mingw.org/). There is also a related project called msys (http://www.mingw.org/wiki/MSYS) that will give you a traditional bash shell (as well as most other standard utilities) in Windows. The run-tests.sh script works just fine there and all the tests pass, using a build of bzip2 from b07b105 ("Accept as many selectors as the file format allows."). > > Cheers, > > Mark