From: Mark Wielaard <mark@klomp.org>
To: bzip2-devel@sourceware.org
Cc: "Ivana Varekova" <varekova@redhat.com>,
"Lubomir Kundrak" <lkundrak@redhat.com>,
"Jakub Martiško" <jamartis@redhat.com>,
"Mark Wielaard" <mark@klomp.org>
Subject: [PATCH] bzip2recover: Fix buffer overflow for large argv[0].
Date: Tue, 01 Jan 2019 00:00:00 -0000 [thread overview]
Message-ID: <1561329293-14814-1-git-send-email-mark@klomp.org> (raw)
Hi,
bzip2 lost its domain and got a new home at https://sourceware.org/bzip2/
It also didn't see a release for a very long time. Causing various patches
used by distros to not have been integrated upstream. We are trying to
collect them all and do a new release.
The following patch comes from Fedora.
Please let us know if we missed some others.
Thanks,
Mark
bzip2recover.c (main) copies argv[0] to a statically sized buffer
without checking whether argv[0] might be too big (> 2000 chars).
This patch comes from Fedora and was originally reported at
https://bugzilla.redhat.com/show_bug.cgi?id=226979
---
bzip2recover.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/bzip2recover.c b/bzip2recover.c
index 06ac1f5..1a70e04 100644
--- a/bzip2recover.c
+++ b/bzip2recover.c
@@ -309,7 +309,8 @@ Int32 main ( Int32 argc, Char** argv )
UInt32 buffHi, buffLo, blockCRC;
Char* p;
- strcpy ( progName, argv[0] );
+ strncpy ( progName, argv[0], BZ_MAX_FILENAME-1);
+ progName[BZ_MAX_FILENAME-1]='\0';
inFileName[0] = outFileName[0] = 0;
fprintf ( stderr,
--
1.8.3.1
reply other threads:[~2019-06-23 22:35 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1561329293-14814-1-git-send-email-mark@klomp.org \
--to=mark@klomp.org \
--cc=bzip2-devel@sourceware.org \
--cc=jamartis@redhat.com \
--cc=lkundrak@redhat.com \
--cc=varekova@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).