public inbox for bzip2-devel@sourceware.org
 help / color / mirror / Atom feed
From: Andreas Schniertshauer <andreas@schniertshauer.de>
To: bzip2-devel@sourceware.org
Subject: bzip2-1.0.8 dlltest.c suggestions/questions
Date: Wed, 01 Jan 2020 00:00:00 -0000	[thread overview]
Message-ID: <183e51d1-9563-d442-cf4a-01740f4f70a8@schniertshauer.de> (raw)

Hi,

the BZ2_LIBNAME in dlltest.c says libbz2-1.0.2.DLL
shouldn't it be 1.0.8?
Is the version number necessary in the filename?
Or could it be libbz2.DLL without the version?

In the same file in function BZ2DLLLoadLibrary a FreeLibrary(hLib); is 
missing in the section
    if (!BZ2_bzlibVersion || !BZ2_bzopen || !BZ2_bzdopen
        || !BZ2_bzread || !BZ2_bzwrite || !BZ2_bzflush
        || !BZ2_bzclose || !BZ2_bzerror) {
       fprintf(stderr,"GetProcAddress failed.\n");

Kind regards,
Andreas.

                 reply	other threads:[~2020-02-21 19:44 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=183e51d1-9563-d442-cf4a-01740f4f70a8@schniertshauer.de \
    --to=andreas@schniertshauer.de \
    --cc=bzip2-devel@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).